content/public/browser/resource_context.h - Issue 840813009: Enable strict-virtual-specifiers for iOS builds.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/browser/resource_context.h

Issue 840813009: Enable strict-virtual-specifiers for iOS builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Review comments Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/public/browser/resource_context.h

diff --git a/content/public/browser/resource_context.h b/content/public/browser/resource_context.h

index 9c15bd62c7c0a884406d11f52068a56e2085771d..3a3fafe0d1aa6dc78d4834c34d216f44c530eec6 100644

--- a/content/public/browser/resource_context.h

+++ b/content/public/browser/resource_context.h

@@ -32,12 +32,10 @@ class AppCacheService;

// the UI thread. It must be destructed on the IO thread.

class CONTENT_EXPORT ResourceContext : public base::SupportsUserData {

public:

-#if defined(OS_IOS)

- virtual ~ResourceContext() {}

-#else

+#if !defined(OS_IOS)

ResourceContext();

- ~ResourceContext() override;

#endif

+ ~ResourceContext() override;

virtual net::HostResolver* GetHostResolver() = 0;

// DEPRECATED: This is no longer a valid given isolated apps/sites and