Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Side by Side Diff: ios/web/navigation/navigation_item_impl_unittest.mm

Issue 840813009: Enable strict-virtual-specifiers for iOS builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Review comments Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ios/web/navigation/navigation_item_impl.h ('k') | ios/web/public/test/test_web_state.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/logging.h" 5 #include "base/logging.h"
6 #include "base/mac/scoped_nsobject.h" 6 #include "base/mac/scoped_nsobject.h"
7 #include "base/memory/scoped_ptr.h" 7 #include "base/memory/scoped_ptr.h"
8 #include "ios/web/navigation/navigation_item_impl.h" 8 #include "ios/web/navigation/navigation_item_impl.h"
9 #include "testing/gtest/include/gtest/gtest.h" 9 #include "testing/gtest/include/gtest/gtest.h"
10 #include "testing/gtest_mac.h" 10 #include "testing/gtest_mac.h"
11 #include "testing/platform_test.h" 11 #include "testing/platform_test.h"
12 12
13 namespace web { 13 namespace web {
14 namespace { 14 namespace {
15 15
16 class NavigationItemTest : public PlatformTest { 16 class NavigationItemTest : public PlatformTest {
17 protected: 17 protected:
18 virtual void SetUp() { 18 void SetUp() override { item_.reset(new NavigationItemImpl()); }
19 item_.reset(new NavigationItemImpl());
20 }
21 19
22 scoped_ptr<NavigationItemImpl> item_; 20 scoped_ptr<NavigationItemImpl> item_;
23 }; 21 };
24 22
25 // TODO(rohitrao): Add and adapt tests from NavigationEntryImpl. 23 // TODO(rohitrao): Add and adapt tests from NavigationEntryImpl.
26 TEST_F(NavigationItemTest, Dummy) { 24 TEST_F(NavigationItemTest, Dummy) {
27 const GURL url("http://init.test"); 25 const GURL url("http://init.test");
28 item_->SetURL(url); 26 item_->SetURL(url);
29 EXPECT_TRUE(item_->GetURL().is_valid()); 27 EXPECT_TRUE(item_->GetURL().is_valid());
30 } 28 }
31 29
32 } // namespace 30 } // namespace
33 } // namespace web 31 } // namespace web
OLDNEW
« no previous file with comments | « ios/web/navigation/navigation_item_impl.h ('k') | ios/web/public/test/test_web_state.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698