ios/chrome/browser/suggestions/suggestions_service_factory.h - Issue 840813009: Enable strict-virtual-specifiers for iOS builds.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/suggestions/suggestions_service_factory.h

Issue 840813009: Enable strict-virtual-specifiers for iOS builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Review comments Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/chrome/browser/suggestions/suggestions_service_factory.h

diff --git a/ios/chrome/browser/suggestions/suggestions_service_factory.h b/ios/chrome/browser/suggestions/suggestions_service_factory.h

index 6f63199447a17b103c60ea409b9dbf91f2fe7441..3f86fc3625f161ecdb3d5a9b99de91c6211bd36d 100644

--- a/ios/chrome/browser/suggestions/suggestions_service_factory.h

+++ b/ios/chrome/browser/suggestions/suggestions_service_factory.h

@@ -33,7 +33,7 @@ class SuggestionsServiceFactory : public BrowserStateKeyedServiceFactory {

friend struct DefaultSingletonTraits<SuggestionsServiceFactory>;

SuggestionsServiceFactory();

- ~SuggestionsServiceFactory();

+ ~SuggestionsServiceFactory() override;

// BrowserStateKeyedServiceFactory:

KeyedService* BuildServiceInstanceFor(