Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Side by Side Diff: ios/web/navigation/navigation_item_impl.h

Issue 840813009: Enable strict-virtual-specifiers for iOS builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Review comments Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef IOS_WEB_NAVIGATION_NAVIGATION_ITEM_IMPL_H_ 5 #ifndef IOS_WEB_NAVIGATION_NAVIGATION_ITEM_IMPL_H_
6 #define IOS_WEB_NAVIGATION_NAVIGATION_ITEM_IMPL_H_ 6 #define IOS_WEB_NAVIGATION_NAVIGATION_ITEM_IMPL_H_
7 7
8 #include "base/basictypes.h" 8 #include "base/basictypes.h"
9 #include "base/memory/scoped_ptr.h" 9 #include "base/memory/scoped_ptr.h"
10 #include "base/strings/string16.h" 10 #include "base/strings/string16.h"
11 #include "ios/web/public/favicon_status.h" 11 #include "ios/web/public/favicon_status.h"
12 #include "ios/web/public/navigation_item.h" 12 #include "ios/web/public/navigation_item.h"
13 #include "ios/web/public/referrer.h" 13 #include "ios/web/public/referrer.h"
14 #include "ios/web/public/ssl_status.h" 14 #include "ios/web/public/ssl_status.h"
15 #include "url/gurl.h" 15 #include "url/gurl.h"
16 16
17 namespace web { 17 namespace web {
18 18
19 // Implementation of NavigationItem. 19 // Implementation of NavigationItem.
20 class NavigationItemImpl : public web::NavigationItem { 20 class NavigationItemImpl : public web::NavigationItem {
21 public: 21 public:
22 // Creates a default NavigationItemImpl. 22 // Creates a default NavigationItemImpl.
23 NavigationItemImpl(); 23 NavigationItemImpl();
24 virtual ~NavigationItemImpl(); 24 ~NavigationItemImpl() override;
25 25
26 // NavigationItem implementation: 26 // NavigationItem implementation:
27 virtual int GetUniqueID() const override; 27 int GetUniqueID() const override;
28 virtual void SetURL(const GURL& url) override; 28 void SetURL(const GURL& url) override;
29 virtual const GURL& GetURL() const override; 29 const GURL& GetURL() const override;
30 virtual void SetReferrer(const web::Referrer& referrer) override; 30 void SetReferrer(const web::Referrer& referrer) override;
31 virtual const web::Referrer& GetReferrer() const override; 31 const web::Referrer& GetReferrer() const override;
32 virtual void SetVirtualURL(const GURL& url) override; 32 void SetVirtualURL(const GURL& url) override;
33 virtual const GURL& GetVirtualURL() const override; 33 const GURL& GetVirtualURL() const override;
34 virtual void SetTitle(const base::string16& title) override; 34 void SetTitle(const base::string16& title) override;
35 virtual const base::string16& GetTitle() const override; 35 const base::string16& GetTitle() const override;
36 virtual void SetPageID(int page_id) override; 36 void SetPageID(int page_id) override;
37 virtual int32 GetPageID() const override; 37 int32 GetPageID() const override;
38 virtual const base::string16& GetTitleForDisplay( 38 const base::string16& GetTitleForDisplay(
39 const std::string& languages) const override; 39 const std::string& languages) const override;
40 virtual void SetTransitionType(ui::PageTransition transition_type) override; 40 void SetTransitionType(ui::PageTransition transition_type) override;
41 virtual ui::PageTransition GetTransitionType() const override; 41 ui::PageTransition GetTransitionType() const override;
42 virtual const FaviconStatus& GetFavicon() const override; 42 const FaviconStatus& GetFavicon() const override;
43 virtual FaviconStatus& GetFavicon() override; 43 FaviconStatus& GetFavicon() override;
44 virtual const SSLStatus& GetSSL() const override; 44 const SSLStatus& GetSSL() const override;
45 virtual SSLStatus& GetSSL() override; 45 SSLStatus& GetSSL() override;
46 virtual void SetTimestamp(base::Time timestamp) override; 46 void SetTimestamp(base::Time timestamp) override;
47 virtual base::Time GetTimestamp() const override; 47 base::Time GetTimestamp() const override;
48 48
49 private: 49 private:
50 int unique_id_; 50 int unique_id_;
51 GURL url_; 51 GURL url_;
52 Referrer referrer_; 52 Referrer referrer_;
53 GURL virtual_url_; 53 GURL virtual_url_;
54 base::string16 title_; 54 base::string16 title_;
55 int32 page_id_; 55 int32 page_id_;
56 ui::PageTransition transition_type_; 56 ui::PageTransition transition_type_;
57 FaviconStatus favicon_; 57 FaviconStatus favicon_;
58 SSLStatus ssl_; 58 SSLStatus ssl_;
59 base::Time timestamp_; 59 base::Time timestamp_;
60 60
61 // This is a cached version of the result of GetTitleForDisplay. When the URL, 61 // This is a cached version of the result of GetTitleForDisplay. When the URL,
62 // virtual URL, or title is set, this should be cleared to force a refresh. 62 // virtual URL, or title is set, this should be cleared to force a refresh.
63 mutable base::string16 cached_display_title_; 63 mutable base::string16 cached_display_title_;
64 64
65 // Copy and assignment is explicitly allowed for this class. 65 // Copy and assignment is explicitly allowed for this class.
66 }; 66 };
67 67
68 } // namespace web 68 } // namespace web
69 69
70 #endif // IOS_WEB_NAVIGATION_NAVIGATION_ITEM_IMPL_H_ 70 #endif // IOS_WEB_NAVIGATION_NAVIGATION_ITEM_IMPL_H_
OLDNEW
« no previous file with comments | « ios/public/test/test_chrome_browser_provider.h ('k') | ios/web/navigation/navigation_item_impl_unittest.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698