Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1615)

Side by Side Diff: ios/web/public/web_state/web_state.h

Issue 840813009: Enable strict-virtual-specifiers for iOS builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Review comments Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ios/web/public/test/test_web_state.h ('k') | net/disk_cache/blockfile/file_ios.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef IOS_WEB_PUBLIC_WEB_STATE_WEB_STATE_H_ 5 #ifndef IOS_WEB_PUBLIC_WEB_STATE_WEB_STATE_H_
6 #define IOS_WEB_PUBLIC_WEB_STATE_WEB_STATE_H_ 6 #define IOS_WEB_PUBLIC_WEB_STATE_WEB_STATE_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/callback_forward.h" 10 #include "base/callback_forward.h"
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
52 // The disposition requested by the navigation source. 52 // The disposition requested by the navigation source.
53 WindowOpenDisposition disposition; 53 WindowOpenDisposition disposition;
54 54
55 // The transition type of navigation. 55 // The transition type of navigation.
56 ui::PageTransition transition; 56 ui::PageTransition transition;
57 57
58 // Whether this navigation is initiated by the renderer process. 58 // Whether this navigation is initiated by the renderer process.
59 bool is_renderer_initiated; 59 bool is_renderer_initiated;
60 }; 60 };
61 61
62 virtual ~WebState() {} 62 ~WebState() override {}
63 63
64 // Gets the BrowserState associated with this WebState. Can never return null. 64 // Gets the BrowserState associated with this WebState. Can never return null.
65 virtual BrowserState* GetBrowserState() const = 0; 65 virtual BrowserState* GetBrowserState() const = 0;
66 66
67 // Opens a URL with the given disposition. The transition specifies how this 67 // Opens a URL with the given disposition. The transition specifies how this
68 // navigation should be recorded in the history system (for example, typed). 68 // navigation should be recorded in the history system (for example, typed).
69 virtual void OpenURL(const OpenURLParams& params) = 0; 69 virtual void OpenURL(const OpenURLParams& params) = 0;
70 70
71 // Gets the NavigationManager associated with this WebState. Can never return 71 // Gets the NavigationManager associated with this WebState. Can never return
72 // null. 72 // null.
(...skipping 51 matching lines...) Expand 10 before | Expand all | Expand 10 after
124 // TODO(droger): Move these methods to WebStateImpl once it is in ios/. 124 // TODO(droger): Move these methods to WebStateImpl once it is in ios/.
125 virtual void AddObserver(WebStateObserver* observer) = 0; 125 virtual void AddObserver(WebStateObserver* observer) = 0;
126 virtual void RemoveObserver(WebStateObserver* observer) = 0; 126 virtual void RemoveObserver(WebStateObserver* observer) = 0;
127 127
128 WebState() {} 128 WebState() {}
129 }; 129 };
130 130
131 } // namespace web 131 } // namespace web
132 132
133 #endif // IOS_WEB_PUBLIC_WEB_STATE_WEB_STATE_H_ 133 #endif // IOS_WEB_PUBLIC_WEB_STATE_WEB_STATE_H_
OLDNEW
« no previous file with comments | « ios/web/public/test/test_web_state.h ('k') | net/disk_cache/blockfile/file_ios.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698