Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Issue 839193002: Move ServiceAccessType into //components/keyed_service (Closed)

Created:
5 years, 11 months ago by sdefresne
Modified:
5 years, 11 months ago
CC:
asanka, benjhayden+dwatch_chromium.org, browser-components-watch_chromium.org, cbentzel+watch_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, davidben+watch_chromium.org, dbeam+watch-ntp_chromium.org, David Black, dhollowa+watch_chromium.org, donnd+watch_chromium.org, dougw+watch_chromium.org, estade+watch_chromium.org, extensions-reviews_chromium.org, gavinp+prer_chromium.org, gcasto+watchlist_chromium.org, grt+watch_chromium.org, Jered, jfweitz+watch_chromium.org, jkarlin+watch_chromium.org, kmadhusu+watch_chromium.org, maniscalco+watch_chromium.org, markusheintz_, maxbogue+watch_chromium.org, melevin+watch_chromium.org, mkwst+watchlist-passwords_chromium.org, mlamouri+watch-notifications_chromium.org, noyau+watch_chromium.org, pam+watch_chromium.org, pedrosimonetti+watch_chromium.org, peter+watch_chromium.org, pvalenzuela+watch_chromium.org, rginda+watch_chromium.org, rouslan+autofillwatch_chromium.org, samarth+watch_chromium.org, shishir+watch_chromium.org, skanuj+watch_chromium.org, James Su, tburkard+watch_chromium.org, tfarina, tim+watch_chromium.org, zea+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move ServiceAccessType into //components/keyed_service The ServiceAccessType is only used when interacting with KeyedServiceFactories so move it into the keyed_service components. Turn the enumeration into a "class enum" so that the value names don't leak into the global namespace. Fix client code and add missing #include after changing the chrome/browser/profiles/profile.h #include into forward declaration in the KeyedServiceFactories headers. Usage of the enumeration was fixed using tools/git/mffr.py. BUG=419366 Committed: https://crrev.com/e9ea3c2ead117e0945df3c9d64c202477fffc99c Cr-Commit-Position: refs/heads/master@{#310979}

Patch Set 1 #

Patch Set 2 : Fix compilation on android #

Unified diffs Side-by-side diffs Delta from patch set Stats (+428 lines, -419 lines) Patch
M chrome/browser/android/favicon_helper.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/android/provider/chrome_browser_provider.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/android/shortcut_helper.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/autocomplete/autocomplete_browsertest.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/autocomplete/chrome_autocomplete_provider_client.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/browser/autocomplete/history_provider.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/autocomplete/history_quick_provider.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/autocomplete/history_quick_provider_unittest.cc View 2 chunks +5 lines, -7 lines 0 comments Download
M chrome/browser/autocomplete/history_url_provider.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/autocomplete/history_url_provider_unittest.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/autocomplete/search_provider_unittest.cc View 2 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/autocomplete/shortcuts_provider.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/autofill/personal_data_manager_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/bookmarks/bookmark_html_writer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/bookmarks/bookmark_html_writer_unittest.cc View 2 chunks +8 lines, -7 lines 0 comments Download
M chrome/browser/bookmarks/chrome_bookmark_client.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/browsing_data/browsing_data_remover.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/browsing_data/browsing_data_remover_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/custom_home_pages_table_model.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/download/download_browsertest.cc View 2 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/download/download_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/download/download_service_factory.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/download/download_target_determiner.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/download/download_target_determiner_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/history/history_api.cc View 7 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/extensions/api/management/chrome_management_api_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/favicon/chrome_favicon_client.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/favicon/favicon_handler_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/favicon/favicon_service.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/favicon/favicon_service_factory.h View 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/favicon/favicon_service_factory.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/browser/favicon/favicon_tab_helper.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/history/android/android_history_provider_service.cc View 12 chunks +24 lines, -24 lines 0 comments Download
M chrome/browser/history/android/sqlite_cursor_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/history/history_browsertest.cc View 5 chunks +10 lines, -11 lines 0 comments Download
M chrome/browser/history/history_service_factory.h View 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser/history/history_service_factory.cc View 2 chunks +9 lines, -7 lines 0 comments Download
M chrome/browser/history/history_tab_helper.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/history/in_memory_url_index.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/history/in_memory_url_index_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/history/redirect_browsertest.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/history/top_sites_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/history/top_sites_impl_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/importer/profile_writer.cc View 3 chunks +9 lines, -7 lines 0 comments Download
M chrome/browser/importer/profile_writer_unittest.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/jumplist_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/notifications/message_center_settings_controller.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/password_manager/chrome_password_manager_client.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/browser/password_manager/password_manager_browsertest.cc View 5 chunks +9 lines, -8 lines 0 comments Download
M chrome/browser/password_manager/password_store_factory.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/password_manager/password_store_factory.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/predictors/autocomplete_action_predictor.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/predictors/autocomplete_action_predictor_unittest.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M chrome/browser/predictors/resource_prefetch_predictor.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/predictors/resource_prefetch_predictor_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/prerender/prerender_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profile_resetter/profile_resetter_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profiles/profile.h View 1 chunk +0 lines, -25 lines 0 comments Download
M chrome/browser/profiles/profile_manager.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/profiles/profile_manager_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/profiles/profile_manager_unittest.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/safe_browsing/browser_feature_extractor.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/safe_browsing/browser_feature_extractor_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/safe_browsing/download_protection_service.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/safe_browsing/download_protection_service_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/safe_browsing/incident_reporting/last_download_finder.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/safe_browsing/incident_reporting/last_download_finder_unittest.cc View 3 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/safe_browsing/malware_details_history.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/malware_details_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_blocking_page.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/search_engines/template_url_service_factory.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/search_engines/template_url_service_test_util.cc View 1 chunk +4 lines, -5 lines 0 comments Download
M chrome/browser/signin/chrome_signin_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ssl/ssl_blocking_page.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/supervised_user/supervised_user_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/supervised_user/supervised_user_navigation_observer.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/glue/autofill_data_type_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/autofill_data_type_controller_unittest.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/sync/glue/autofill_profile_data_type_controller.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/glue/bookmark_change_processor.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/sync/glue/bookmark_data_type_controller.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/glue/favicon_cache.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/glue/password_data_type_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/sync_backend_registrar.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/sync/glue/typed_url_data_type_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/profile_sync_components_factory_impl.cc View 1 3 chunks +5 lines, -6 lines 0 comments Download
M chrome/browser/sync/profile_sync_service.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/sync/profile_sync_service_autofill_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/sessions/notification_service_sessions_router.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/test/integration/autofill_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/test/integration/bookmarks_helper.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/sync/test/integration/passwords_helper.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/browser/sync/test/integration/sync_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/test/integration/typed_urls_helper.cc View 4 chunks +9 lines, -15 lines 0 comments Download
M chrome/browser/ui/android/navigation_popup.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/autofill/autofill_dialog_controller_unittest.cc View 1 chunk +5 lines, -6 lines 0 comments Download
M chrome/browser/ui/autofill/chrome_autofill_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/history_menu_bridge.mm View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/passwords/manage_password_item_view_controller_unittest.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/find_bar/find_bar_host_browsertest.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M chrome/browser/ui/omnibox/alternate_nav_infobar_delegate.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/omnibox/omnibox_view_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/passwords/manage_passwords_bubble_model.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/passwords/manage_passwords_ui_controller.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/passwords/password_manager_presenter.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/ui/search/instant_extended_interactive_uitest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/search_engines/keyword_editor_controller.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/sync/one_click_signin_helper.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/sync/profile_signin_confirmation_helper_unittest.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/ui/toolbar/back_forward_menu_model.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/toolbar/back_forward_menu_model_unittest.cc View 1 chunk +6 lines, -7 lines 0 comments Download
M chrome/browser/ui/toolbar/recent_tabs_sub_menu_model.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/test_with_browser_view.cc View 1 chunk +4 lines, -5 lines 0 comments Download
M chrome/browser/ui/website_settings/website_settings.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/bidi_checker_web_ui_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/extensions/extension_icon_source.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/favicon_source.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/history_ui.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/ntp/app_launcher_handler.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/ntp/favicon_webui_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/ntp/suggestions_source_top_sites.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/omnibox/omnibox_ui_handler.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/webdata/web_data_service_factory.h View 2 chunks +11 lines, -13 lines 0 comments Download
M chrome/browser/webdata/web_data_service_factory.cc View 7 chunks +11 lines, -8 lines 0 comments Download
M chrome/test/base/profile_mock.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/testing_profile.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/base/ui_test_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/webui/history_ui_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/keyed_service.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M components/keyed_service/core/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A components/keyed_service/core/service_access_type.h View 1 chunk +34 lines, -0 lines 0 comments Download
M components/search_engines/template_url_service_unittest.cc View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
sdefresne
The interesting changes are in: - components/keyed_service.gypi - components/keyed_service/core/BUILD.gn - components/keyed_service/core/service_access_type.h - chrome/browser/profiles/profile.h All the ...
5 years, 11 months ago (2015-01-09 10:01:10 UTC) #4
jochen (gone - plz use gerrit)
lgtm assuming erg reviews this as well
5 years, 11 months ago (2015-01-09 13:04:35 UTC) #5
Elliot Glaysher
lgtm
5 years, 11 months ago (2015-01-09 18:21:13 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/839193002/20001
5 years, 11 months ago (2015-01-10 09:05:56 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-10 10:10:40 UTC) #9
commit-bot: I haz the power
5 years, 11 months ago (2015-01-10 10:11:19 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e9ea3c2ead117e0945df3c9d64c202477fffc99c
Cr-Commit-Position: refs/heads/master@{#310979}

Powered by Google App Engine
This is Rietveld 408576698