chrome/browser/ui/passwords/manage_passwords_bubble_model.cc - Issue 839193002: Move ServiceAccessType into //components/keyed_service

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/passwords/manage_passwords_bubble_model.cc

Issue 839193002: Move ServiceAccessType into //components/keyed_service (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix compilation on android Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/omnibox/omnibox_view_browsertest.cc ('k') | chrome/browser/ui/passwords/manage_passwords_ui_controller.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/passwords/manage_passwords_bubble_model.cc

diff --git a/chrome/browser/ui/passwords/manage_passwords_bubble_model.cc b/chrome/browser/ui/passwords/manage_passwords_bubble_model.cc

index f0c201d75c0a28eeead98daf581cbd817ce010dc..d2473760db142a42fda759a7831dbccb29fa7a4a 100644

--- a/chrome/browser/ui/passwords/manage_passwords_bubble_model.cc

+++ b/chrome/browser/ui/passwords/manage_passwords_bubble_model.cc

@@ -5,6 +5,7 @@

#include "chrome/browser/ui/passwords/manage_passwords_bubble_model.h"

#include "chrome/browser/password_manager/password_store_factory.h"

+#include "chrome/browser/profiles/profile.h"

#include "chrome/browser/ui/browser.h"

#include "chrome/browser/ui/browser_finder.h"

#include "chrome/browser/ui/passwords/manage_passwords_ui_controller.h"

@@ -306,8 +307,8 @@ void ManagePasswordsBubbleModel::OnPasswordAction(

Profile* profile =

Profile::FromBrowserContext(web_contents()->GetBrowserContext());

password_manager::PasswordStore* password_store =

- PasswordStoreFactory::GetForProfile(profile, Profile::EXPLICIT_ACCESS)

- .get();

+ PasswordStoreFactory::GetForProfile(

+ profile, ServiceAccessType::EXPLICIT_ACCESS).get();

DCHECK(password_store);

if (action == REMOVE_PASSWORD)

password_store->RemoveLogin(password_form);