chrome/browser/password_manager/chrome_password_manager_client.cc - Issue 839193002: Move ServiceAccessType into //components/keyed_service

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/password_manager/chrome_password_manager_client.cc

Issue 839193002: Move ServiceAccessType into //components/keyed_service (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix compilation on android Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/notifications/message_center_settings_controller.cc ('k') | chrome/browser/password_manager/password_manager_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/password_manager/chrome_password_manager_client.cc

diff --git a/chrome/browser/password_manager/chrome_password_manager_client.cc b/chrome/browser/password_manager/chrome_password_manager_client.cc

index f5604c40af73aab566eaae846565872c5db21f90..a69d75cc400baba6de89d137f20963f192f4d326 100644

--- a/chrome/browser/password_manager/chrome_password_manager_client.cc

+++ b/chrome/browser/password_manager/chrome_password_manager_client.cc

@@ -266,9 +266,10 @@ password_manager::PasswordStore*

ChromePasswordManagerClient::GetPasswordStore() {

// Always use EXPLICIT_ACCESS as the password manager checks IsOffTheRecord

// itself when it shouldn't access the PasswordStore.

- // TODO(gcasto): Is is safe to change this to Profile::IMPLICIT_ACCESS?

- return PasswordStoreFactory::GetForProfile(profile_, Profile::EXPLICIT_ACCESS)

- .get();

+ // TODO(gcasto): Is is safe to change this to

+ // ServiceAccessType::IMPLICIT_ACCESS?

+ return PasswordStoreFactory::GetForProfile(

+ profile_, ServiceAccessType::EXPLICIT_ACCESS).get();

}

base::FieldTrial::Probability