chrome/browser/sync/glue/favicon_cache.cc - Issue 839193002: Move ServiceAccessType into //components/keyed_service

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/glue/favicon_cache.cc

Issue 839193002: Move ServiceAccessType into //components/keyed_service (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix compilation on android Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sync/glue/bookmark_data_type_controller.cc ('k') | chrome/browser/sync/glue/password_data_type_controller.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync/glue/favicon_cache.cc

diff --git a/chrome/browser/sync/glue/favicon_cache.cc b/chrome/browser/sync/glue/favicon_cache.cc

index f591fe4fa24baefd3d234a439e9cce04dcaa5234..342a049a3f680b4adf7a27992278e9b06e32f419 100644

--- a/chrome/browser/sync/glue/favicon_cache.cc

+++ b/chrome/browser/sync/glue/favicon_cache.cc

@@ -434,8 +434,8 @@ void FaviconCache::OnPageFaviconUpdated(const GURL& page_url) {

page_task_map_[page_url] = 0; // For testing only.

return;

}

- FaviconService* favicon_service =

- FaviconServiceFactory::GetForProfile(profile_, Profile::EXPLICIT_ACCESS);

+ FaviconService* favicon_service = FaviconServiceFactory::GetForProfile(

+ profile_, ServiceAccessType::EXPLICIT_ACCESS);

if (!favicon_service)

return;

// TODO(zea): This appears to only fetch one favicon (best match based on