chrome/browser/ui/cocoa/history_menu_bridge.mm - Issue 839193002: Move ServiceAccessType into //components/keyed_service

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/history_menu_bridge.mm

Issue 839193002: Move ServiceAccessType into //components/keyed_service (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix compilation on android Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/autofill/chrome_autofill_client.cc ('k') | chrome/browser/ui/cocoa/passwords/manage_password_item_view_controller_unittest.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/history_menu_bridge.mm

diff --git a/chrome/browser/ui/cocoa/history_menu_bridge.mm b/chrome/browser/ui/cocoa/history_menu_bridge.mm

index 1f43718a276b4743154cabee24a627d6be80d9d6..bd9045310e440771ea4b0fe3bfe85d7eca1685c2 100644

--- a/chrome/browser/ui/cocoa/history_menu_bridge.mm

+++ b/chrome/browser/ui/cocoa/history_menu_bridge.mm

@@ -74,7 +74,7 @@ HistoryMenuBridge::HistoryMenuBridge(Profile* profile)

// may not be ready when the Bridge is created. If this happens, register

// for a notification that tells us the HistoryService is ready.

HistoryService* hs = HistoryServiceFactory::GetForProfile(

- profile_, Profile::EXPLICIT_ACCESS);

+ profile_, ServiceAccessType::EXPLICIT_ACCESS);

if (hs) {

history_service_observer_.Add(hs);

if (hs->BackendLoaded()) {

@@ -432,8 +432,8 @@ HistoryMenuBridge::HistoryItem* HistoryMenuBridge::HistoryItemForTab(

}

void HistoryMenuBridge::GetFaviconForHistoryItem(HistoryItem* item) {

- FaviconService* service =

- FaviconServiceFactory::GetForProfile(profile_, Profile::EXPLICIT_ACCESS);

+ FaviconService* service = FaviconServiceFactory::GetForProfile(

+ profile_, ServiceAccessType::EXPLICIT_ACCESS);

base::CancelableTaskTracker::TaskId task_id =

service->GetFaviconImageForPageURL(

item->url,