Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 822713002: Update from https://crrev.com/309415 (Closed)

Created:
6 years ago by qsr
Modified:
5 years, 11 months ago
Reviewers:
jamesr
CC:
mojo-reviews_chromium.org, ojan, esprehn, yzshen+watch_chromium.org, abarth-chromium
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+8295 lines, -4471 lines) Patch
M DEPS View 2 chunks +6 lines, -6 lines 0 comments Download
M base/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M base/atomicops_internals_x86_msvc.h View 1 chunk +0 lines, -3 lines 0 comments Download
M base/base.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M base/bind_internal.h View 10 chunks +39 lines, -23 lines 0 comments Download
M base/bind_internal.h.pump View 1 chunk +8 lines, -6 lines 0 comments Download
M base/callback_unittest.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M base/debug/trace_event_impl.h View 3 chunks +3 lines, -7 lines 0 comments Download
M base/debug/trace_event_impl.cc View 7 chunks +9 lines, -22 lines 0 comments Download
M base/files/file_path_watcher_linux.cc View 2 chunks +32 lines, -9 lines 0 comments Download
M base/i18n/char_iterator.h View 1 chunk +1 line, -1 line 0 comments Download
M base/json/json_value_converter.h View 2 chunks +13 lines, -22 lines 0 comments Download
A base/json/json_value_converter.cc View 1 chunk +37 lines, -0 lines 0 comments Download
M base/logging.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/mac/authorization_util.mm View 1 chunk +1 line, -1 line 0 comments Download
M base/mac/launch_services_util.cc View 1 chunk +1 line, -0 lines 0 comments Download
M base/mac/mac_util.h View 1 chunk +0 lines, -3 lines 0 comments Download
M base/memory/discardable_memory_shmem.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M base/memory/discardable_shared_memory.h View 3 chunks +37 lines, -11 lines 0 comments Download
M base/memory/discardable_shared_memory.cc View 7 chunks +149 lines, -22 lines 0 comments Download
M base/memory/discardable_shared_memory_unittest.cc View 9 chunks +72 lines, -32 lines 0 comments Download
M base/prefs/pref_service.h View 2 chunks +9 lines, -0 lines 0 comments Download
M base/prefs/pref_service.cc View 2 chunks +10 lines, -0 lines 0 comments Download
M base/prefs/pref_value_store.h View 1 chunk +1 line, -0 lines 0 comments Download
M base/prefs/pref_value_store.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M base/process/process_metrics.h View 1 chunk +3 lines, -0 lines 0 comments Download
M base/process/process_metrics_ios.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M base/process/process_metrics_posix.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M base/process/process_metrics_win.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M base/strings/stringprintf.h View 4 chunks +4 lines, -7 lines 0 comments Download
M base/strings/stringprintf.cc View 6 chunks +7 lines, -5 lines 0 comments Download
M base/strings/stringprintf_unittest.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M base/timer/timer.h View 1 chunk +1 line, -1 line 0 comments Download
M base/win/win_util.cc View 1 chunk +0 lines, -26 lines 0 comments Download
M build/all.gyp View 1 chunk +1 line, -1 line 0 comments Download
M build/android/pylib/android_commands.py View 1 chunk +2 lines, -1 line 0 comments Download
M build/android/pylib/remote/device/remote_device_environment.py View 2 chunks +25 lines, -5 lines 0 comments Download
M build/android/pylib/remote/device/remote_device_gtest_run.py View 1 chunk +10 lines, -5 lines 0 comments Download
D build/asan.saves View 1 chunk +0 lines, -23 lines 0 comments Download
M build/common.gypi View 7 chunks +19 lines, -41 lines 0 comments Download
M build/config/android/rules.gni View 1 chunk +3 lines, -0 lines 0 comments Download
M cc/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/animation/animation.cc View 2 chunks +8 lines, -6 lines 0 comments Download
M cc/animation/keyframed_animation_curve_unittest.cc View 1 chunk +95 lines, -0 lines 0 comments Download
M cc/animation/timing_function.h View 1 chunk +22 lines, -0 lines 0 comments Download
M cc/animation/timing_function.cc View 2 chunks +38 lines, -0 lines 0 comments Download
M cc/base/util.h View 1 chunk +4 lines, -2 lines 0 comments Download
M cc/blink/web_filter_animation_curve_impl.h View 1 chunk +4 lines, -0 lines 0 comments Download
M cc/blink/web_filter_animation_curve_impl.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M cc/blink/web_float_animation_curve_impl.h View 1 chunk +4 lines, -0 lines 0 comments Download
M cc/blink/web_float_animation_curve_impl.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M cc/blink/web_transform_animation_curve_impl.h View 1 chunk +4 lines, -0 lines 0 comments Download
M cc/blink/web_transform_animation_curve_impl.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M cc/cc.gyp View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/debug/rasterize_and_record_benchmark_impl.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M cc/layers/picture_layer_impl.h View 3 chunks +3 lines, -3 lines 0 comments Download
M cc/layers/picture_layer_impl.cc View 16 chunks +60 lines, -41 lines 0 comments Download
M cc/layers/picture_layer_impl_perftest.cc View 8 chunks +12 lines, -31 lines 0 comments Download
M cc/layers/picture_layer_impl_unittest.cc View 8 chunks +41 lines, -69 lines 0 comments Download
M cc/layers/ui_resource_layer.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M cc/layers/ui_resource_layer_unittest.cc View 1 chunk +18 lines, -0 lines 0 comments Download
M cc/layers/video_layer_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/output/geometry_binding.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M cc/output/gl_renderer.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M cc/quads/largest_draw_quad.cc View 1 chunk +27 lines, -27 lines 0 comments Download
M cc/quads/render_pass_id.cc View 1 chunk +2 lines, -2 lines 0 comments Download
D cc/resources/managed_tile_state.h View 1 chunk +0 lines, -101 lines 0 comments Download
D cc/resources/managed_tile_state.cc View 1 chunk +0 lines, -61 lines 0 comments Download
M cc/resources/picture.cc View 3 chunks +34 lines, -29 lines 0 comments Download
M cc/resources/picture_layer_tiling.h View 7 chunks +16 lines, -20 lines 0 comments Download
M cc/resources/picture_layer_tiling.cc View 13 chunks +41 lines, -51 lines 0 comments Download
M cc/resources/picture_layer_tiling_perftest.cc View 4 chunks +12 lines, -4 lines 0 comments Download
M cc/resources/picture_layer_tiling_set.h View 2 chunks +7 lines, -14 lines 0 comments Download
M cc/resources/picture_layer_tiling_set.cc View 7 chunks +30 lines, -90 lines 0 comments Download
M cc/resources/picture_layer_tiling_set_unittest.cc View 8 chunks +183 lines, -293 lines 0 comments Download
M cc/resources/picture_layer_tiling_unittest.cc View 42 chunks +133 lines, -147 lines 0 comments Download
M cc/resources/raster_source.h View 1 chunk +3 lines, -0 lines 0 comments Download
M cc/resources/tile.h View 5 chunks +14 lines, -17 lines 0 comments Download
M cc/resources/tile.cc View 2 chunks +13 lines, -9 lines 0 comments Download
A cc/resources/tile_draw_info.h View 1 chunk +80 lines, -0 lines 0 comments Download
A cc/resources/tile_draw_info.cc View 1 chunk +37 lines, -0 lines 0 comments Download
M cc/resources/tile_manager.h View 2 chunks +3 lines, -5 lines 0 comments Download
M cc/resources/tile_manager.cc View 11 chunks +36 lines, -48 lines 0 comments Download
M cc/resources/tile_manager_perftest.cc View 12 chunks +28 lines, -48 lines 0 comments Download
M cc/resources/tile_manager_unittest.cc View 13 chunks +47 lines, -39 lines 0 comments Download
M cc/resources/tile_task_worker_pool.h View 2 chunks +4 lines, -0 lines 0 comments Download
M cc/resources/tile_task_worker_pool.cc View 3 chunks +9 lines, -3 lines 0 comments Download
M cc/resources/tile_task_worker_pool_perftest.cc View 3 chunks +12 lines, -1 line 0 comments Download
M cc/resources/tiling_set_eviction_queue.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M cc/scheduler/scheduler_state_machine.cc View 3 chunks +8 lines, -4 lines 1 comment Download
M cc/scheduler/scheduler_state_machine_unittest.cc View 6 chunks +78 lines, -9 lines 0 comments Download
M cc/scheduler/scheduler_unittest.cc View 1 chunk +8 lines, -4 lines 0 comments Download
M cc/surfaces/surface_aggregator.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/surfaces/surface_aggregator_unittest.cc View 1 chunk +33 lines, -0 lines 0 comments Download
M cc/test/fake_external_begin_frame_source.h View 1 chunk +1 line, -0 lines 0 comments Download
M cc/test/fake_external_begin_frame_source.cc View 1 chunk +12 lines, -4 lines 0 comments Download
M cc/test/fake_picture_layer_impl.h View 1 chunk +1 line, -3 lines 0 comments Download
M cc/test/fake_picture_layer_impl.cc View 2 chunks +7 lines, -19 lines 0 comments Download
M cc/test/fake_picture_layer_tiling_client.h View 3 chunks +10 lines, -4 lines 0 comments Download
M cc/test/fake_picture_layer_tiling_client.cc View 4 chunks +14 lines, -10 lines 0 comments Download
M cc/test/fake_picture_pile_impl.h View 1 chunk +8 lines, -0 lines 0 comments Download
M cc/test/fake_picture_pile_impl.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M cc/test/test_context_provider.cc View 1 chunk +2 lines, -1 line 0 comments Download
M cc/trees/property_tree_builder.cc View 1 chunk +1 line, -1 line 0 comments Download
D crypto/PRESUBMIT.py View 1 chunk +0 lines, -17 lines 0 comments Download
M crypto/p224.cc View 2 chunks +14 lines, -0 lines 0 comments Download
A + gpu/angle_end2end_tests_main.cc View 2 chunks +3 lines, -4 lines 0 comments Download
A gpu/blink/BUILD.gn View 1 chunk +39 lines, -0 lines 0 comments Download
A gpu/blink/DEPS View 1 chunk +4 lines, -0 lines 0 comments Download
A gpu/blink/gpu_blink.gyp View 1 chunk +48 lines, -0 lines 0 comments Download
A gpu/blink/gpu_blink_export.h View 1 chunk +29 lines, -0 lines 0 comments Download
A gpu/blink/webgraphicscontext3d_impl.h View 1 chunk +612 lines, -0 lines 0 comments Download
A gpu/blink/webgraphicscontext3d_impl.cc View 1 chunk +1030 lines, -0 lines 0 comments Download
M gpu/command_buffer/build_gles2_cmd_buffer.py View 2 chunks +11 lines, -8 lines 0 comments Download
M gpu/command_buffer/client/cmd_buffer_helper.h View 3 chunks +6 lines, -3 lines 0 comments Download
M gpu/command_buffer/client/cmd_buffer_helper_test.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M gpu/command_buffer/client/share_group.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M gpu/command_buffer/common/cmd_buffer_common.h View 15 chunks +90 lines, -76 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_format.h View 4 chunks +41 lines, -37 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_format_autogen.h View 247 chunks +2371 lines, -2231 lines 0 comments Download
M gpu/command_buffer/service/common_decoder_unittest.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M gpu/command_buffer/service/feature_info.cc View 3 chunks +9 lines, -9 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_clear_framebuffer.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_copy_texture_chromium.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.h View 1 chunk +4 lines, -2 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc View 1 chunk +2 lines, -1 line 0 comments Download
M gpu/command_buffer/service/in_process_command_buffer.cc View 3 chunks +68 lines, -1 line 0 comments Download
M gpu/config/gpu_driver_bug_list_json.cc View 2 chunks +14 lines, -1 line 0 comments Download
M gpu/config/gpu_info.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M gpu/config/software_rendering_list_json.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M gpu/gpu.gyp View 2 chunks +30 lines, -16 lines 0 comments Download
M net/android/javatests/src/org/chromium/net/NetworkChangeNotifierTest.java View 2 chunks +34 lines, -4 lines 0 comments Download
M net/cert/cert_verify_proc_unittest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M net/cookies/cookie_monster.cc View 2 chunks +9 lines, -2 lines 0 comments Download
M net/disk_cache/blockfile/storage_block.h View 1 chunk +3 lines, -3 lines 0 comments Download
M net/http/http_network_session.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/http/http_network_session.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M net/http/http_network_transaction_unittest.cc View 1 chunk +17 lines, -19 lines 0 comments Download
M net/quic/congestion_control/cubic.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/congestion_control/hybrid_slow_start.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/quic/congestion_control/hybrid_slow_start_test.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M net/quic/crypto/cached_network_parameters.h View 2 chunks +4 lines, -0 lines 0 comments Download
M net/quic/crypto/cached_network_parameters.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/crypto/quic_crypto_server_config.h View 5 chunks +47 lines, -5 lines 0 comments Download
M net/quic/crypto/quic_crypto_server_config.cc View 9 chunks +152 lines, -30 lines 0 comments Download
M net/quic/crypto/quic_crypto_server_config_test.cc View 4 chunks +306 lines, -88 lines 0 comments Download
M net/quic/crypto/source_address_token.h View 3 chunks +30 lines, -1 line 0 comments Download
M net/quic/crypto/source_address_token.cc View 1 chunk +24 lines, -0 lines 0 comments Download
M net/quic/quic_ack_notifier.cc View 1 chunk +1 line, -2 lines 0 comments Download
M net/quic/quic_ack_notifier_manager.cc View 3 chunks +38 lines, -42 lines 0 comments Download
M net/quic/quic_connection.cc View 4 chunks +4 lines, -11 lines 0 comments Download
M net/quic/quic_connection_test.cc View 4 chunks +4 lines, -15 lines 0 comments Download
M net/quic/quic_crypto_server_stream.h View 2 chunks +4 lines, -0 lines 0 comments Download
M net/quic/quic_crypto_server_stream.cc View 4 chunks +2 lines, -5 lines 0 comments Download
M net/quic/quic_flags.h View 1 chunk +2 lines, -1 line 0 comments Download
M net/quic/quic_flags.cc View 2 chunks +8 lines, -8 lines 0 comments Download
M net/quic/quic_headers_stream.cc View 2 chunks +4 lines, -1 line 0 comments Download
M net/quic/quic_headers_stream_test.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M net/quic/quic_packet_generator.cc View 3 chunks +25 lines, -0 lines 0 comments Download
M net/quic/quic_packet_generator_test.cc View 2 chunks +25 lines, -0 lines 0 comments Download
M net/quic/quic_sent_packet_manager.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M net/quic/quic_sent_packet_manager_test.cc View 1 chunk +13 lines, -0 lines 0 comments Download
M net/quic/quic_session_test.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M net/quic/quic_stream_factory.h View 2 chunks +6 lines, -0 lines 0 comments Download
M net/quic/quic_stream_factory.cc View 3 chunks +22 lines, -5 lines 0 comments Download
M net/quic/quic_stream_factory_test.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/socket/client_socket_pool_base.h View 1 chunk +1 line, -1 line 0 comments Download
M net/socket/ssl_client_socket_openssl.h View 1 chunk +4 lines, -2 lines 0 comments Download
M net/socket/ssl_client_socket_openssl.cc View 7 chunks +50 lines, -28 lines 0 comments Download
M net/socket/transport_client_socket_pool.cc View 2 chunks +16 lines, -0 lines 0 comments Download
M net/spdy/hpack_encoder.cc View 2 chunks +2 lines, -12 lines 0 comments Download
M net/spdy/hpack_encoder_test.cc View 3 chunks +17 lines, -16 lines 0 comments Download
M net/spdy/hpack_round_trip_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/spdy/spdy_framer.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/spdy/spdy_framer.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/spdy/spdy_headers_block_parser.h View 1 chunk +0 lines, -4 lines 0 comments Download
M net/spdy/spdy_headers_block_parser.cc View 1 chunk +0 lines, -15 lines 0 comments Download
M net/spdy/spdy_headers_block_parser_test.cc View 2 chunks +2 lines, -1 line 0 comments Download
M net/spdy/spdy_protocol.h View 1 chunk +2 lines, -0 lines 0 comments Download
M net/spdy/write_blocked_list.h View 3 chunks +26 lines, -5 lines 0 comments Download
M net/spdy/write_blocked_list_test.cc View 2 chunks +56 lines, -1 line 0 comments Download
M skia/config/SkUserConfig.h View 1 chunk +0 lines, -12 lines 0 comments Download
M skia/ext/benchmarking_canvas.cc View 1 chunk +1 line, -1 line 0 comments Download
M skia/ext/image_operations.cc View 1 chunk +0 lines, -1 line 0 comments Download
M skia/ext/skia_utils_mac_unittest.mm View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/platform/graphics/DeferredImageDecoderTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/platform/graphics/UnacceleratedImageBufferSurface.cpp View 1 chunk +4 lines, -1 line 0 comments Download
M testing/chromoting/browser_test_commands_linux.txt View 1 chunk +1 line, -0 lines 0 comments Download
M testing/chromoting/browser_tests_launcher.py View 5 chunks +61 lines, -11 lines 0 comments Download
A + testing/commit_queue/OWNERS View 1 chunk +3 lines, -1 line 0 comments Download
A testing/commit_queue/config.json View 1 chunk +105 lines, -0 lines 0 comments Download
A + third_party/android_platform/LICENSE View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/android_platform/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download
A + third_party/android_platform/README.chromium View 2 chunks +1 line, -5 lines 0 comments Download
A + third_party/android_platform/development/scripts/stack View 6 chunks +10 lines, -31 lines 0 comments Download
A + third_party/android_platform/development/scripts/stack_core.py View 5 chunks +6 lines, -17 lines 0 comments Download
A + third_party/android_platform/development/scripts/symbol.py View 9 chunks +37 lines, -33 lines 0 comments Download
A third_party/android_platform/webview/frameworks_1597296.jar View Binary file 0 comments Download
A third_party/android_platform/webview/frameworks_1597296_manifest.xml View 1 chunk +507 lines, -0 lines 0 comments Download
M third_party/mesa/README.chromium View 1 chunk +5 lines, -0 lines 0 comments Download
D third_party/tcmalloc/PRESUBMIT.py View 1 chunk +0 lines, -16 lines 0 comments Download
M tools/android/forwarder2/host_forwarder_main.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M tools/gritsettings/resource_ids View 1 chunk +1 line, -1 line 0 comments Download
M tools/msan/blacklist.txt View 1 chunk +4 lines, -1 line 0 comments Download
M tools/valgrind/gtest_exclude/components_unittests.gtest.txt View 1 chunk +3 lines, -0 lines 0 comments Download
M tools/valgrind/memcheck/PRESUBMIT.py View 1 chunk +0 lines, -10 lines 0 comments Download
M ui/gfx/transform.h View 1 chunk +5 lines, -0 lines 0 comments Download
M ui/gl/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/gl/gl.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
A + ui/gl/gl_image_glx.h View 2 chunks +15 lines, -15 lines 0 comments Download
A ui/gl/gl_image_glx.cc View 1 chunk +209 lines, -0 lines 0 comments Download
M ui/gl/gl_surface_mac.cc View 1 chunk +0 lines, -1 line 0 comments Download
M url/url_canon.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (1 generated)
qsr
Committed patchset #1 (id:1) manually as 0461682287658c6b5d1fb6fd5eef3319774899a6.
6 years ago (2014-12-22 12:08:26 UTC) #1
jamesr
FYI, something in this update made it so no app using surfaces can draw. mojo:sample_app ...
5 years, 11 months ago (2014-12-29 23:06:28 UTC) #3
jamesr
https://codereview.chromium.org/822713002/diff/1/cc/scheduler/scheduler_state_machine.cc File cc/scheduler/scheduler_state_machine.cc (right): https://codereview.chromium.org/822713002/diff/1/cc/scheduler/scheduler_state_machine.cc#newcode346 cc/scheduler/scheduler_state_machine.cc:346: if (output_surface_state_ != OUTPUT_SURFACE_ACTIVE) this is what breaks - ...
5 years, 11 months ago (2014-12-29 23:17:41 UTC) #4
jamesr
Fix here: https://codereview.chromium.org/827163002
5 years, 11 months ago (2014-12-30 00:39:57 UTC) #5
qsr
On 2014/12/29 23:17:41, jamesr wrote: > https://codereview.chromium.org/822713002/diff/1/cc/scheduler/scheduler_state_machine.cc > File cc/scheduler/scheduler_state_machine.cc (right): > > https://codereview.chromium.org/822713002/diff/1/cc/scheduler/scheduler_state_machine.cc#newcode346 > ...
5 years, 11 months ago (2015-01-05 13:16:08 UTC) #6
jamesr
5 years, 11 months ago (2015-01-05 21:37:35 UTC) #7
Message was sent while issue was closed.
I don't.  I would recommend locally trying out a few basic things
(mojo/tools/mojo_demo.sh --{browser,wm_flow}, ./sky/tools/skydb) locally when
doing a roll.  It's probably easier to just manually spot check some things than
try to construct automated tests at this stage.

Powered by Google App Engine
This is Rietveld 408576698