Update from https://crrev.com/309415

cc/resources/picture_layer_tiling_set.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/resources/picture_layer_tiling_set.h"
 
 #include <limits>
 #include <set>
 #include <vector>
 
@@ skipping 36 matching lines @@
       skewport_target_time_in_seconds_(skewport_target_time_in_seconds),
       skewport_extrapolation_limit_in_content_pixels_(
           skewport_extrapolation_limit_in_content_pixels),
       client_(client) {
 }
 
 PictureLayerTilingSet::~PictureLayerTilingSet() {
 }
 
 void PictureLayerTilingSet::UpdateTilingsToCurrentRasterSource(
-    RasterSource* raster_source,
+    scoped_refptr<RasterSource> raster_source,
     const PictureLayerTilingSet* twin_set,
     const Region& layer_invalidation,
-    float minimum_contents_scale) {
+    float minimum_contents_scale,
+    float maximum_contents_scale) {
   RemoveTilingsBelowScale(minimum_contents_scale);
-
-  gfx::Size layer_bounds = raster_source->GetSize();
+  RemoveTilingsAboveScale(maximum_contents_scale);
 
   // Copy over tilings that are shared with the |twin_set| tiling set (if it
   // exists).
   if (twin_set) {
     for (PictureLayerTiling* twin_tiling : twin_set->tilings_) {
       float contents_scale = twin_tiling->contents_scale();
       DCHECK_GE(contents_scale, minimum_contents_scale);
+      DCHECK_LE(contents_scale, maximum_contents_scale);
 
       PictureLayerTiling* this_tiling = FindTilingWithScale(contents_scale);
       if (!this_tiling) {
         scoped_ptr<PictureLayerTiling> new_tiling = PictureLayerTiling::Create(
-            contents_scale, layer_bounds, client_, max_tiles_for_interest_area_,
-            skewport_target_time_in_seconds_,
+            contents_scale, raster_source, client_,
+            max_tiles_for_interest_area_, skewport_target_time_in_seconds_,
             skewport_extrapolation_limit_in_content_pixels_);
         tilings_.push_back(new_tiling.Pass());
         this_tiling = tilings_.back();
       }
       this_tiling->CloneTilesAndPropertiesFrom(*twin_tiling);
     }
   }
 
   // For unshared tilings, invalidate tiles and update them to the new raster
   // source.
   for (PictureLayerTiling* tiling : tilings_) {
     if (twin_set && twin_set->FindTilingWithScale(tiling->contents_scale()))
       continue;
 
-    tiling->Resize(layer_bounds);
+    tiling->SetRasterSourceAndResize(raster_source);
     tiling->Invalidate(layer_invalidation);
-    tiling->SetRasterSource(raster_source);
+    tiling->SetRasterSourceOnTiles();
     // This is needed for cases where the live tiles rect didn't change but
     // recordings exist in the raster source that did not exist on the last
     // raster source.
     tiling->CreateMissingTilesInLiveTilesRect();
 
     // If |twin_set| is present, use the resolutions from there. Otherwise leave
     // all resolutions as they are.
     if (twin_set)
       tiling->set_resolution(NON_IDEAL_RESOLUTION);
   }
 
   tilings_.sort(LargestToSmallestScaleFunctor());
 
 #if DCHECK_IS_ON
   for (PictureLayerTiling* tiling : tilings_) {
     DCHECK(tiling->tile_size() ==
            client_->CalculateTileSize(tiling->tiling_size()))
         << "tile_size: " << tiling->tile_size().ToString()
         << " tiling_size: " << tiling->tiling_size().ToString()
         << " CalculateTileSize: "
         << client_->CalculateTileSize(tiling->tiling_size()).ToString();
   }
 
   if (!tilings_.empty()) {
     size_t num_high_res = std::count_if(tilings_.begin(), tilings_.end(),
                                         [](PictureLayerTiling* tiling) {
       return tiling->resolution() == HIGH_RESOLUTION;
     });
-    DCHECK_EQ(1u, num_high_res);
+    DCHECK_LE(num_high_res, 1u);
+    // When commiting from the main thread the high res tiling may get dropped,
+    // but when cloning to the active tree, there should always be one.
+    if (twin_set)
+      DCHECK_EQ(1u, num_high_res);
   }
 #endif
 }
 
 void PictureLayerTilingSet::CleanUpTilings(
     float min_acceptable_high_res_scale,
     float max_acceptable_high_res_scale,
     const std::vector<PictureLayerTiling*>& needed_tilings,
     bool should_have_low_res,
     PictureLayerTilingSet* twin_set,
@@ skipping 50 matching lines @@
     return t->resolution() == NON_IDEAL_RESOLUTION;
   });
   tilings_.erase(to_remove, tilings_.end());
 }
 
 void PictureLayerTilingSet::MarkAllTilingsNonIdeal() {
   for (auto* tiling : tilings_)
     tiling->set_resolution(NON_IDEAL_RESOLUTION);
 }
 
-bool PictureLayerTilingSet::SyncTilingsForTesting(
-    const PictureLayerTilingSet& other,
-    const gfx::Size& new_layer_bounds,
-    const Region& layer_invalidation,
-    float minimum_contents_scale,
-    RasterSource* raster_source) {
-  if (new_layer_bounds.IsEmpty()) {
-    RemoveAllTilings();
-    return false;
-  }
-
-  tilings_.reserve(other.tilings_.size());
-
-  // Remove any tilings that aren't in |other| or don't meet the minimum.
-  for (size_t i = 0; i < tilings_.size(); ++i) {
-    float scale = tilings_[i]->contents_scale();
-    if (scale >= minimum_contents_scale && !!other.FindTilingWithScale(scale))
-      continue;
-    // Swap with the last element and remove it.
-    tilings_.swap(tilings_.begin() + i, tilings_.end() - 1);
-    tilings_.pop_back();
-    --i;
-  }
-
-  bool have_high_res_tiling = false;
-
-  // Add any missing tilings from |other| that meet the minimum.
-  for (size_t i = 0; i < other.tilings_.size(); ++i) {
-    float contents_scale = other.tilings_[i]->contents_scale();
-    if (contents_scale < minimum_contents_scale)
-      continue;
-    if (PictureLayerTiling* this_tiling = FindTilingWithScale(contents_scale)) {
-      this_tiling->set_resolution(other.tilings_[i]->resolution());
-
-      this_tiling->Resize(new_layer_bounds);
-      this_tiling->Invalidate(layer_invalidation);
-      this_tiling->SetRasterSource(raster_source);
-      this_tiling->CreateMissingTilesInLiveTilesRect();
-      if (this_tiling->resolution() == HIGH_RESOLUTION)
-        have_high_res_tiling = true;
-
-      DCHECK(this_tiling->tile_size() ==
-             client_->CalculateTileSize(this_tiling->tiling_size()))
-          << "tile_size: " << this_tiling->tile_size().ToString()
-          << " tiling_size: " << this_tiling->tiling_size().ToString()
-          << " CalculateTileSize: "
-          << client_->CalculateTileSize(this_tiling->tiling_size()).ToString();
-      continue;
-    }
-    scoped_ptr<PictureLayerTiling> new_tiling = PictureLayerTiling::Create(
-        contents_scale, new_layer_bounds, client_, max_tiles_for_interest_area_,
-        skewport_target_time_in_seconds_,
-        skewport_extrapolation_limit_in_content_pixels_);
-    new_tiling->set_resolution(other.tilings_[i]->resolution());
-    if (new_tiling->resolution() == HIGH_RESOLUTION)
-      have_high_res_tiling = true;
-    tilings_.push_back(new_tiling.Pass());
-  }
-  tilings_.sort(LargestToSmallestScaleFunctor());
-
-  return have_high_res_tiling;
-}
-
 PictureLayerTiling* PictureLayerTilingSet::AddTiling(
     float contents_scale,
-    const gfx::Size& layer_bounds) {
-  for (size_t i = 0; i < tilings_.size(); ++i)
+    scoped_refptr<RasterSource> raster_source) {
+  for (size_t i = 0; i < tilings_.size(); ++i) {
     DCHECK_NE(tilings_[i]->contents_scale(), contents_scale);
+    DCHECK_EQ(tilings_[i]->raster_source(), raster_source.get());
+  }
 
   tilings_.push_back(PictureLayerTiling::Create(
-      contents_scale, layer_bounds, client_, max_tiles_for_interest_area_,
+      contents_scale, raster_source, client_, max_tiles_for_interest_area_,
       skewport_target_time_in_seconds_,
       skewport_extrapolation_limit_in_content_pixels_));
   PictureLayerTiling* appended = tilings_.back();
 
   tilings_.sort(LargestToSmallestScaleFunctor());
   return appended;
 }
 
 int PictureLayerTilingSet::NumHighResTilings() const {
   int num_high_res = 0;
@@ skipping 25 matching lines @@
 }
 
 void PictureLayerTilingSet::RemoveTilingsBelowScale(float minimum_scale) {
   auto to_remove =
       tilings_.remove_if([minimum_scale](PictureLayerTiling* tiling) {
         return tiling->contents_scale() < minimum_scale;
       });
   tilings_.erase(to_remove, tilings_.end());
 }
 
+void PictureLayerTilingSet::RemoveTilingsAboveScale(float maximum_scale) {
+  auto to_remove =
+      tilings_.remove_if([maximum_scale](PictureLayerTiling* tiling) {
+        return tiling->contents_scale() > maximum_scale;
+      });
+  tilings_.erase(to_remove, tilings_.end());
+}
+
 void PictureLayerTilingSet::RemoveAllTilings() {
   tilings_.clear();
 }
 
 void PictureLayerTilingSet::Remove(PictureLayerTiling* tiling) {
   ScopedPtrVector<PictureLayerTiling>::iterator iter =
     std::find(tilings_.begin(), tilings_.end(), tiling);
   if (iter == tilings_.end())
     return;
   tilings_.erase(iter);
@@ skipping 27 matching lines @@
   // The first tiling has the largest contents scale.
   return tilings_[0]->contents_scale();
 }
 
 bool PictureLayerTilingSet::UpdateTilePriorities(
     const gfx::Rect& required_rect_in_layer_space,
     float ideal_contents_scale,
     double current_frame_time_in_seconds,
     const Occlusion& occlusion_in_layer_space,
     bool can_require_tiles_for_activation) {
-  bool tiling_needs_update = false;
-  // TODO(vmpstr): Check if we have to early out here, or if we can just do it
-  // as part of computing tile priority rects for tilings.
-  for (auto* tiling : tilings_) {
-    if (tiling->NeedsUpdateForFrameAtTimeAndViewport(
-            current_frame_time_in_seconds, required_rect_in_layer_space)) {
-      tiling_needs_update = true;
-      break;
-    }
-  }
-  if (!tiling_needs_update)
-    return false;
-
+  bool updated = false;
   for (auto* tiling : tilings_) {
     tiling->set_can_require_tiles_for_activation(
         can_require_tiles_for_activation);
-    tiling->ComputeTilePriorityRects(
+    updated |= tiling->ComputeTilePriorityRects(
         required_rect_in_layer_space, ideal_contents_scale,
         current_frame_time_in_seconds, occlusion_in_layer_space);
   }
-  return true;
+  return updated;
 }
 
 void PictureLayerTilingSet::GetAllTilesForTracing(
     std::set<const Tile*>* tiles) const {
   for (auto* tiling : tilings_)
     tiling->GetAllTilesForTracing(tiles);
 }
 
 PictureLayerTilingSet::CoverageIterator::CoverageIterator(
     const PictureLayerTilingSet* set,
@@ skipping 215 matching lines @@
     case LOWER_THAN_LOW_RES:
       range = TilingRange(low_res_range.end, tilings_.size());
       break;
   }
 
   DCHECK_LE(range.start, range.end);
   return range;
 }
 
 }  // namespace cc