Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 819133004: Make callers of CommandLine use it via the base:: namespace. (Closed)

Created:
5 years, 12 months ago by Avi (use Gerrit)
Modified:
5 years, 11 months ago
CC:
chromium-reviews, asanka, vandebo (ex-Chrome), felt, yusukes+watch_chromium.org, tzik, hguihot+watch_chromium.org, browser-components-watch_chromium.org, mikhal+watch_chromium.org, yukishiino+watch_chromium.org, rginda+watch_chromium.org, noyau+watch_chromium.org, dmazzoni+watch_chromium.org, markusheintz_, aandrey+blink_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, vsevik, Greg Billock, tommycli, aboxhall+watch_chromium.org, dzhioev+watch_chromium.org, nona+watch_chromium.org, devtools-reviews_chromium.org, chromium-apps-reviews_chromium.org, miu+watch_chromium.org, hubbe+watch_chromium.org, imcheng+watch_chromium.org, jasonroberts+watch_google.com, yuzo+watch_chromium.org, paulirish+reviews_chromium.org, pam+watch_chromium.org, nhiroki, oshima+watch_chromium.org, rouslan+autofillwatch_chromium.org, chrome-apps-syd-reviews_chromium.org, hclam+watch_chromium.org, plundblad+watch_chromium.org, Lei Zhang, tfarina, avayvod+watch_chromium.org, yurys, pwestin+watch_google.com, benjhayden+dwatch_chromium.org, pfeldman, dtseng+watch_chromium.org, estade+watch_chromium.org, James Su, kinuko+fileapi, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make callers of CommandLine use it via the base:: namespace. Covers chrome/app* and chrome/browser/* through e. BUG=422426 TEST=none TBR=ben@chromium.org Committed: https://crrev.com/3ef9ec9e43e5e5b7aca6ea935407a469d7b528cf Cr-Commit-Position: refs/heads/master@{#309476}

Patch Set 1 #

Patch Set 2 : fix #

Patch Set 3 : fix #

Patch Set 4 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+858 lines, -781 lines) Patch
M chrome/app/chrome_crash_reporter_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/chrome_crash_reporter_client_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/chrome_exe_main_win.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M chrome/app/chrome_main_delegate.cc View 7 chunks +10 lines, -7 lines 0 comments Download
M chrome/app/client_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app_shim/app_mode_loader_mac.mm View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/app_shim/chrome_main_app_mode_mac.mm View 4 chunks +8 lines, -8 lines 0 comments Download
M chrome/app_shim/win/app_shim_main.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/about_flags.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/about_flags.cc View 8 chunks +18 lines, -18 lines 0 comments Download
M chrome/browser/about_flags_unittest.cc View 17 chunks +24 lines, -24 lines 0 comments Download
M chrome/browser/accessibility/accessibility_extension_apitest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/android/chrome_startup_flags.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/android/chrome_web_contents_delegate_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/android/dev_tools_server.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/android/dom_distiller/feedback_reporter_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/android/voice_search_tab_helper.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/app_controller_mac.mm View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/app_controller_mac_browsertest.mm View 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/app_mode/app_mode_utils.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/apps/app_browsertest.cc View 6 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/apps/app_browsertest_util.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/apps/app_shim/app_shim_interactive_uitest_mac.mm View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/apps/app_shim/app_shim_quit_interactive_uitest_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/apps/app_url_redirector_browsertest.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/apps/ephemeral_app_launcher.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/apps/ephemeral_app_launcher_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/apps/ephemeral_app_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/apps/ephemeral_app_throttle.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/apps/guest_view/app_view_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/apps/guest_view/web_view_browsertest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/apps/shortcut_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/apps/speech_recognition_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/apps/window_controls_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/autocomplete_browsertest.cc View 4 chunks +8 lines, -4 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_provider_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/search_provider_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/autofill/autofill_browsertest.cc View 3 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/background/background_contents_service.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/background/background_contents_service_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/background/background_contents_service_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/background/background_mode_manager.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/background/background_mode_manager_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/background/background_mode_manager_unittest.cc View 7 chunks +19 lines, -22 lines 0 comments Download
M chrome/browser/background/background_mode_manager_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/bookmarks/bookmark_model_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/bookmarks/enhanced_bookmarks_features.cc View 5 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/browser_process_impl.cc View 6 chunks +14 lines, -11 lines 0 comments Download
M chrome/browser/browser_process_platform_part_aurawin.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browser_shutdown.cc View 1 chunk +9 lines, -6 lines 0 comments Download
M chrome/browser/chrome_browser_field_trials.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chrome_browser_field_trials_desktop.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chrome_browser_field_trials_mobile.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chrome_browser_main.cc View 1 7 chunks +11 lines, -9 lines 0 comments Download
M chrome/browser/chrome_browser_main_android.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chrome_browser_main_mac.mm View 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/chrome_browser_main_win.cc View 7 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 8 chunks +15 lines, -10 lines 0 comments Download
M chrome/browser/chrome_content_browser_client_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chrome_content_browser_client_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chrome_main_browsertest.cc View 6 chunks +10 lines, -7 lines 0 comments Download
M chrome/browser/chrome_net_benchmarking_message_filter.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/chrome_process_finder_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chrome_process_singleton_win_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chrome_security_exploit_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chrome_switches_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/accessibility/accessibility_manager_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/accessibility/magnification_controller_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/accessibility/magnification_manager_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/app_mode/fake_cws.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/app_mode/kiosk_app_manager_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/app_mode/kiosk_app_update_service_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/app_mode/kiosk_mode_idle_app_name_notification.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/background/ash_user_wallpaper_delegate.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/chrome_browser_main_chromeos.cc View 3 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/customization/customization_wallpaper_downloader_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/drive/drive_notification_manager_factory_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/events/event_rewriter.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/events/event_rewriter_unittest.cc View 7 chunks +12 lines, -12 lines 0 comments Download
M chrome/browser/chromeos/extensions/echo_private_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/event_router.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/input_method_api.cc View 1 chunk +4 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/extensions/input_method_apitest_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/virtual_keyboard_browsertest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/wallpaper_private_api.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/file_manager/file_browser_handlers.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/file_manager/file_manager_browsertest.cc View 4 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/file_manager/file_tasks.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/file_manager/file_tasks_unittest.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/file_manager/open_with_browser.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/first_run/first_run.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/auth/cryptohome_authenticator_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/chrome_restart_request.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/login/crash_restore_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/demo_mode/demo_app_launcher_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/enrollment/auto_enrollment_controller.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/enrollment/enrollment_screen_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/existing_user_controller.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/existing_user_controller_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/fake_login_utils.cc View 1 chunk +3 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/login/helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/hwid_checker.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/kiosk_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/lock/screen_locker_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/login_browsertest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/login/login_manager_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/login_screen_policy_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/login_ui_keyboard_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/login_utils.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/login_utils_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/oobe_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/resource_loader_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/saml/saml_browsertest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/screens/error_screen.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/screenshot_testing/screenshot_tester.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/session/user_session_manager.cc View 14 chunks +24 lines, -24 lines 0 comments Download
M chrome/browser/chromeos/login/session_login_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/signin/oauth2_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/signin/oauth2_login_manager.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/supervised/supervised_user_login_flow.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/test/oobe_base_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/test/wizard_in_process_browser_test.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/ui/captive_portal_window_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/ui/login_display_host_impl.cc View 4 chunks +8 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/login/users/chrome_user_manager_impl.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/users/user_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager_browsertest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager_policy_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/wizard_controller.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/login/wizard_controller_browsertest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/net/network_portal_detector_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/net/network_portal_detector_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/net/network_portal_notification_controller.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/net/network_portal_notification_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/ownership/owner_settings_service_chromeos.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/policy/blocking_login_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/browser_policy_connector_chromeos.cc View 3 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/policy/device_local_account_browsertest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/policy/device_local_account_policy_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/device_system_use_24hour_clock_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/enrollment_handler_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/login_screen_default_policy_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/policy/power_policy_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/policy/ticl_device_settings_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/user_cloud_policy_manager_factory_chromeos.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/preferences.cc View 3 chunks +6 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/preferences_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/profiles/profile_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/settings/cros_settings.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/settings/owner_flags_storage.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/system/device_disabling_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/system/device_disabling_manager.cc View 3 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/system/device_disabling_manager_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/system/input_device_settings_impl_x11.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/system/tray_accessibility_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/system_logs/command_line_log_source.cc View 2 chunks +11 lines, -11 lines 0 comments Download
M chrome/browser/chromeos/system_logs/debug_log_writer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/system_logs/touch_log_source_x11.cc View 1 chunk +6 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/ui/idle_app_name_notification_view_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/component_updater/chrome_component_updater_configurator.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/component_updater/pepper_flash_component_installer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/component_updater/recovery_component_installer.cc View 6 chunks +9 lines, -7 lines 0 comments Download
M chrome/browser/content_settings/content_settings_browsertest.cc View 9 chunks +16 lines, -9 lines 0 comments Download
M chrome/browser/devtools/device/port_forwarding_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/devtools/devtools_sanity_browsertest.cc View 6 chunks +8 lines, -6 lines 0 comments Download
M chrome/browser/devtools/devtools_ui_bindings.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/diagnostics/diagnostics_controller.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/diagnostics/diagnostics_controller_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/diagnostics/diagnostics_model.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/diagnostics/diagnostics_model_unittest.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/dom_distiller/dom_distiller_viewer_source_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/dom_distiller/profile_utils.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/dom_distiller/tab_utils_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/domain_reliability/service_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/download/download_browsertest.cc View 8 chunks +10 lines, -8 lines 0 comments Download
M chrome/browser/download/save_package_file_picker.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/download/save_page_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/errorpage_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/activity_log/activity_database.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/activity_log/activity_database_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/activity_log/activity_log.cc View 4 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/extensions/activity_log/activity_log_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/activity_log/activity_log_enabled_unittest.cc View 4 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/extensions/activity_log/activity_log_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/activity_log/counting_policy_unittest.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/extensions/activity_log/fullstream_ui_policy_unittest.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/extensions/all_urls_apitest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/activity_log_private/activity_log_private_apitest.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/extensions/api/braille_display_private/braille_display_private_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/cast_streaming/cast_streaming_apitest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/cast_streaming/performance_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/cloud_print_private/cloud_print_private_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/command_line_private/command_line_private_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/content_settings/content_settings_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/debugger/debugger_api.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/debugger/debugger_extension_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/desktop_capture/desktop_capture_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/dial/dial_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/enterprise_platform_keys/enterprise_platform_keys_apitest_nss.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/feedback_private/feedback_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/file_system/file_system_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/gcd_private/gcd_private_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/gcm/gcm_apitest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/history/history_api.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/identity/identity_apitest.cc View 8 chunks +12 lines, -8 lines 0 comments Download
M chrome/browser/extensions/api/log_private/log_private_api_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/management/management_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/mdns/mdns_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/media_galleries/media_galleries_apitest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/media_galleries/media_galleries_watch_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/media_galleries_private/media_galleries_watch_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/messaging/native_process_launcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/messaging/native_process_launcher_posix.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/messaging/native_process_launcher_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/networking_private/networking_private_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/networking_private/networking_private_chromeos_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/networking_private/networking_private_service_client_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/page_capture/page_capture_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/permissions/permissions_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/preferences_private/preferences_private_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/push_messaging/push_messaging_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/push_messaging/push_messaging_canary_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/screenlock_private/screenlock_private_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/sessions/sessions_apitest.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/streams_private/streams_private_apitest.cc View 5 chunks +10 lines, -5 lines 0 comments Download
M chrome/browser/extensions/api/tab_capture/tab_capture_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/tab_capture/tab_capture_apitest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/tab_capture/tab_capture_performancetest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/terminal/terminal_private_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/virtual_keyboard_private/chrome_virtual_keyboard_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/webstore_private/webstore_private_apitest.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/extensions/app_background_page_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/app_process_apitest.cc View 3 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/extensions/background_app_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/bundle_installer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/chrome_app_api_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/chrome_extensions_browser_client.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/chrome_process_manager_delegate.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/chrome_ui_overrides_browsertest.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/extensions/component_loader.cc View 6 chunks +12 lines, -6 lines 0 comments Download
M chrome/browser/extensions/convert_web_app_browsertest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/crx_installer_browsertest.cc View 2 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/extensions/extension_action_icon_factory_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_apitest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_assets_manager_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_disabled_ui_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_gcm_app_handler_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_icon_source_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_install_ui_browsertest.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_keybinding_apitest.cc View 3 chunks +6 lines, -9 lines 0 comments Download
M chrome/browser/extensions/extension_message_bubble_controller_unittest.cc View 3 chunks +5 lines, -7 lines 0 comments Download
M chrome/browser/extensions/extension_messages_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_resource_request_policy_apitest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_service.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_service_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/extension_special_storage_policy.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_startup_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_system_impl.cc View 4 chunks +15 lines, -18 lines 0 comments Download
M chrome/browser/extensions/extension_tabs_apitest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_ui_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_util.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_web_ui_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/external_component_loader.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/external_provider_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/external_provider_impl_chromeos_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/external_provider_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/install_signer.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/install_verifier.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/extensions/location_bar_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/pack_extension_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/page_action_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/plugin_apitest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/process_management_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/signin/gaia_auth_extension_loader.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/startup_helper.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/startup_helper_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/test_extension_environment.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/test_extension_system.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/updater/extension_updater_unittest.cc View 1 chunk +3 lines, -6 lines 0 comments Download
M chrome/browser/extensions/webstore_installer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/webstore_installer_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/window_open_apitest.cc View 5 chunks +9 lines, -6 lines 0 comments Download
M chrome/browser/extensions/window_open_interactive_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/external_extension_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/819133004/60001
5 years, 12 months ago (2014-12-22 22:11:28 UTC) #2
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 12 months ago (2014-12-22 22:50:58 UTC) #3
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/3ef9ec9e43e5e5b7aca6ea935407a469d7b528cf Cr-Commit-Position: refs/heads/master@{#309476}
5 years, 12 months ago (2014-12-22 22:51:40 UTC) #4
Lei Zhang
5 years, 11 months ago (2015-01-05 20:27:08 UTC) #6
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698