chrome/browser/extensions/startup_helper.cc - Issue 819133004: Make callers of CommandLine use it via the base:: namespace.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/startup_helper.cc

Issue 819133004: Make callers of CommandLine use it via the base:: namespace. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/signin/gaia_auth_extension_loader.cc ('k') | chrome/browser/extensions/startup_helper_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/startup_helper.cc

diff --git a/chrome/browser/extensions/startup_helper.cc b/chrome/browser/extensions/startup_helper.cc

index b90fed3cd9b87896a376fea0c4f63ce76ab8a954..4432e7ff819d48616d09877b621b6c295961210b 100644

--- a/chrome/browser/extensions/startup_helper.cc

+++ b/chrome/browser/extensions/startup_helper.cc

@@ -94,7 +94,7 @@ void StartupHelper::OnPackFailure(const std::string& error_message,

PrintPackExtensionMessage(error_message);

}

-bool StartupHelper::PackExtension(const CommandLine& cmd_line) {

+bool StartupHelper::PackExtension(const base::CommandLine& cmd_line) {

if (!cmd_line.HasSwitch(switches::kPackExtension))

return false;

@@ -205,7 +205,7 @@ class ValidateCrxHelper : public SandboxedUnpackerClient {

} // namespace

-bool StartupHelper::ValidateCrx(const CommandLine& cmd_line,

+bool StartupHelper::ValidateCrx(const base::CommandLine& cmd_line,

std::string* error) {

CHECK(error);

base::FilePath path = cmd_line.GetSwitchValuePath(switches::kValidateCrx);

@@ -304,7 +304,7 @@ void AppInstallHelper::OnAppInstallComplete(bool success,

} // namespace

-bool StartupHelper::InstallEphemeralApp(const CommandLine& cmd_line,

+bool StartupHelper::InstallEphemeralApp(const base::CommandLine& cmd_line,

Profile* profile) {

std::string id =

cmd_line.GetSwitchValueASCII(switches::kInstallEphemeralAppFromWebstore);