Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Side by Side Diff: chrome/browser/chrome_browser_main_android.cc

Issue 819133004: Make callers of CommandLine use it via the base:: namespace. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/chrome_browser_main.cc ('k') | chrome/browser/chrome_browser_main_mac.mm » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/chrome_browser_main_android.h" 5 #include "chrome/browser/chrome_browser_main_android.h"
6 6
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "base/debug/trace_event.h" 8 #include "base/debug/trace_event.h"
9 #include "base/path_service.h" 9 #include "base/path_service.h"
10 #include "chrome/browser/bookmarks/enhanced_bookmarks_features.h" 10 #include "chrome/browser/bookmarks/enhanced_bookmarks_features.h"
(...skipping 24 matching lines...) Expand all
35 // TODO(jcivelli): we should not initialize the crash-reporter when it was not 35 // TODO(jcivelli): we should not initialize the crash-reporter when it was not
36 // enabled. Right now if it is disabled we still generate the minidumps but we 36 // enabled. Right now if it is disabled we still generate the minidumps but we
37 // do not upload them. 37 // do not upload them.
38 bool breakpad_enabled = true; 38 bool breakpad_enabled = true;
39 #else 39 #else
40 bool breakpad_enabled = false; 40 bool breakpad_enabled = false;
41 #endif 41 #endif
42 42
43 // Allow Breakpad to be enabled in Chromium builds for testing purposes. 43 // Allow Breakpad to be enabled in Chromium builds for testing purposes.
44 if (!breakpad_enabled) 44 if (!breakpad_enabled)
45 breakpad_enabled = CommandLine::ForCurrentProcess()->HasSwitch( 45 breakpad_enabled = base::CommandLine::ForCurrentProcess()->HasSwitch(
46 switches::kEnableCrashReporterForTesting); 46 switches::kEnableCrashReporterForTesting);
47 47
48 if (breakpad_enabled) { 48 if (breakpad_enabled) {
49 base::FilePath crash_dump_dir; 49 base::FilePath crash_dump_dir;
50 PathService::Get(chrome::DIR_CRASH_DUMPS, &crash_dump_dir); 50 PathService::Get(chrome::DIR_CRASH_DUMPS, &crash_dump_dir);
51 crash_dump_manager_.reset(new breakpad::CrashDumpManager(crash_dump_dir)); 51 crash_dump_manager_.reset(new breakpad::CrashDumpManager(crash_dump_dir));
52 } 52 }
53 53
54 ChromeBrowserMainParts::PreProfileInit(); 54 ChromeBrowserMainParts::PreProfileInit();
55 } 55 }
56 56
(...skipping 30 matching lines...) Expand all
87 "ChromeBrowserMainPartsAndroid::PreEarlyInitialization:StartUiMsgLoop"); 87 "ChromeBrowserMainPartsAndroid::PreEarlyInitialization:StartUiMsgLoop");
88 base::MessageLoopForUI::current()->Start(); 88 base::MessageLoopForUI::current()->Start();
89 } 89 }
90 90
91 ChromeBrowserMainParts::PreEarlyInitialization(); 91 ChromeBrowserMainParts::PreEarlyInitialization();
92 } 92 }
93 93
94 void ChromeBrowserMainPartsAndroid::ShowMissingLocaleMessageBox() { 94 void ChromeBrowserMainPartsAndroid::ShowMissingLocaleMessageBox() {
95 NOTREACHED(); 95 NOTREACHED();
96 } 96 }
OLDNEW
« no previous file with comments | « chrome/browser/chrome_browser_main.cc ('k') | chrome/browser/chrome_browser_main_mac.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698