Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(643)

Side by Side Diff: chrome/browser/extensions/api/messaging/native_process_launcher_win.cc

Issue 819133004: Make callers of CommandLine use it via the base:: namespace. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix Created 5 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/api/messaging/native_process_launcher.h" 5 #include "chrome/browser/extensions/api/messaging/native_process_launcher.h"
6 6
7 #include <windows.h> 7 #include <windows.h>
8 8
9 #include "base/command_line.h" 9 #include "base/command_line.h"
10 #include "base/logging.h" 10 #include "base/logging.h"
(...skipping 70 matching lines...) Expand 10 before | Expand all | Expand 10 after
81 if (!manifest_path.IsAbsolute()) { 81 if (!manifest_path.IsAbsolute()) {
82 *error_message = "Path to native messaging host manifest must be absolute."; 82 *error_message = "Path to native messaging host manifest must be absolute.";
83 return base::FilePath(); 83 return base::FilePath();
84 } 84 }
85 85
86 return manifest_path; 86 return manifest_path;
87 } 87 }
88 88
89 // static 89 // static
90 bool NativeProcessLauncher::LaunchNativeProcess( 90 bool NativeProcessLauncher::LaunchNativeProcess(
91 const CommandLine& command_line, 91 const base::CommandLine& command_line,
92 base::Process* process, 92 base::Process* process,
93 base::File* read_file, 93 base::File* read_file,
94 base::File* write_file) { 94 base::File* write_file) {
95 // Timeout for the IO pipes. 95 // Timeout for the IO pipes.
96 const DWORD kTimeoutMs = 5000; 96 const DWORD kTimeoutMs = 5000;
97 97
98 // Windows will use default buffer size when 0 is passed to 98 // Windows will use default buffer size when 0 is passed to
99 // CreateNamedPipeW(). 99 // CreateNamedPipeW().
100 const DWORD kBufferSize = 0; 100 const DWORD kBufferSize = 0;
101 101
(...skipping 68 matching lines...) Expand 10 before | Expand all | Expand 10 after
170 } 170 }
171 171
172 *process = cmd_process.Pass(); 172 *process = cmd_process.Pass();
173 *read_file = base::File(stdout_pipe.Take()); 173 *read_file = base::File(stdout_pipe.Take());
174 *write_file = base::File(stdin_pipe.Take()); 174 *write_file = base::File(stdin_pipe.Take());
175 175
176 return true; 176 return true;
177 } 177 }
178 178
179 } // namespace extensions 179 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698