chrome/browser/extensions/extension_keybinding_apitest.cc - Issue 819133004: Make callers of CommandLine use it via the base:: namespace.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_keybinding_apitest.cc

Issue 819133004: Make callers of CommandLine use it via the base:: namespace. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_install_ui_browsertest.cc ('k') | chrome/browser/extensions/extension_message_bubble_controller_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_keybinding_apitest.cc

diff --git a/chrome/browser/extensions/extension_keybinding_apitest.cc b/chrome/browser/extensions/extension_keybinding_apitest.cc

index 29c93a7d8d6152b408f85c03cebf46b6fc1c1256..b6372230e3a86e2681e2a09cd9bd9a6d6ef2c47d 100644

--- a/chrome/browser/extensions/extension_keybinding_apitest.cc

+++ b/chrome/browser/extensions/extension_keybinding_apitest.cc

@@ -276,9 +276,8 @@ IN_PROC_BROWSER_TEST_F(CommandsApiTest, OverwriteBookmarkShortcut) {

ASSERT_TRUE(ui_test_utils::BringBrowserWindowToFront(browser()));

// This functionality requires a feature flag.

- CommandLine::ForCurrentProcess()->AppendSwitchASCII(

- "--enable-override-bookmarks-ui",

- "1");

+ base::CommandLine::ForCurrentProcess()->AppendSwitchASCII(

+ "--enable-override-bookmarks-ui", "1");

ASSERT_TRUE(RunExtensionTest("keybinding/overwrite_bookmark_shortcut"))

<< message_;

@@ -321,9 +320,8 @@ IN_PROC_BROWSER_TEST_F(CommandsApiTest,

ASSERT_TRUE(ui_test_utils::BringBrowserWindowToFront(browser()));

// This functionality requires a feature flag.

- CommandLine::ForCurrentProcess()->AppendSwitchASCII(

- "--enable-override-bookmarks-ui",

- "1");

+ base::CommandLine::ForCurrentProcess()->AppendSwitchASCII(

+ "--enable-override-bookmarks-ui", "1");

ASSERT_TRUE(RunExtensionTest("keybinding/overwrite_bookmark_shortcut"))

<< message_;

@@ -365,9 +363,8 @@ IN_PROC_BROWSER_TEST_F(CommandsApiTest,

ASSERT_TRUE(ui_test_utils::BringBrowserWindowToFront(browser()));

// This functionality requires a feature flag.

- CommandLine::ForCurrentProcess()->AppendSwitchASCII(

- "--enable-override-bookmarks-ui",

- "1");

+ base::CommandLine::ForCurrentProcess()->AppendSwitchASCII(

+ "--enable-override-bookmarks-ui", "1");

ASSERT_TRUE(RunExtensionTest("keybinding/basics"))

<< message_;