chrome/browser/apps/app_shim/app_shim_interactive_uitest_mac.mm - Issue 819133004: Make callers of CommandLine use it via the base:: namespace.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/apps/app_shim/app_shim_interactive_uitest_mac.mm

Issue 819133004: Make callers of CommandLine use it via the base:: namespace. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/apps/app_browsertest_util.cc ('k') | chrome/browser/apps/app_shim/app_shim_quit_interactive_uitest_mac.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/apps/app_shim/app_shim_interactive_uitest_mac.mm

diff --git a/chrome/browser/apps/app_shim/app_shim_interactive_uitest_mac.mm b/chrome/browser/apps/app_shim/app_shim_interactive_uitest_mac.mm

index e2e4982ac69fcc0d2af3cbb97d8f610c61a6f003..2b1e0020325bb7f4e6c0bca6ca0752085509d3b3 100644

--- a/chrome/browser/apps/app_shim/app_shim_interactive_uitest_mac.mm

+++ b/chrome/browser/apps/app_shim/app_shim_interactive_uitest_mac.mm

@@ -409,7 +409,7 @@ IN_PROC_BROWSER_TEST_F(AppShimInteractiveTest, MAYBE_HostedAppLaunch) {

// Case 2: Launch the shim, it should start the hosted app.

{

HostedAppBrowserListObserver listener(app->id());

- CommandLine shim_cmdline(CommandLine::NO_PROGRAM);

+ base::CommandLine shim_cmdline(base::CommandLine::NO_PROGRAM);

shim_cmdline.AppendSwitch(app_mode::kLaunchedForTest);

ProcessSerialNumber shim_psn;

ASSERT_TRUE(base::mac::OpenApplicationWithPath(

@@ -483,7 +483,7 @@ IN_PROC_BROWSER_TEST_F(AppShimInteractiveTest, MAYBE_Launch) {

// Case 2: Launch the shim, it should start the app.

{

ExtensionTestMessageListener launched_listener("Launched", false);

- CommandLine shim_cmdline(CommandLine::NO_PROGRAM);

+ base::CommandLine shim_cmdline(base::CommandLine::NO_PROGRAM);

shim_cmdline.AppendSwitch(app_mode::kLaunchedForTest);

ProcessSerialNumber shim_psn;

ASSERT_TRUE(base::mac::OpenApplicationWithPath(

@@ -692,7 +692,7 @@ IN_PROC_BROWSER_TEST_F(AppShimInteractiveTest, MAYBE_RebuildShim) {

// (3) After rebuilding, Chrome again launches the shim and expects it to

// behave normally.

ExtensionTestMessageListener launched_listener("Launched", false);

- CommandLine shim_cmdline(CommandLine::NO_PROGRAM);

+ base::CommandLine shim_cmdline(base::CommandLine::NO_PROGRAM);

ASSERT_TRUE(base::mac::OpenApplicationWithPath(

shim_path, shim_cmdline, kLSLaunchDefaults, NULL));