Update freetype to 2.5.4.

Update freetype to 2.5.4.

Put freetype into third_party directory, cleaning up header files.

Previously freetype header files are in core/src/fxge/freetype and core/include/thirdparties. There were also multiple fx_freetype.h.

This patch removes the additional Foxit wrapper to make further update easier.

Notice, for original freetype source code, the following files are modified and need to be updated accordingly in future update:

third_party/freetype/include/config/ftmodule.h
third_party/freetype/include/config/ftoption.h

BUG=407341
R=thestig@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/e4fc5ced45c8fcfbe2487ec64eab036bc7d57602

[Bo Xu, 2014-12-19 19:34:29]

bo_xu@foxitsoftware.com changed reviewers:
+ thestig@chromium.org, tsepez@chromium.org

[Bo Xu, 2014-12-19 19:34:36]

Hi Tom and Lei, please review this CL. I am not quite sure of what I am doing on
the BUILD.gn file, so please suggest on anything bad there.

[Tom Sepez, 2014-12-19 20:10:00]

On 2014/12/19 19:34:36, Bo Xu wrote:
> Hi Tom and Lei, please review this CL. I am not quite sure of what I am doing
on
> the BUILD.gn file, so please suggest on anything bad there.

The first thing to do is to check that your GN build works.  I usually do this
in a parallel build directory:

$ gn gen out_gn/Default
$ ninja -C out_gn/Default pdfium_test chrome

Can you try this after applying your patch?

[Tom Sepez, 2014-12-19 20:16:08]

tsepez@chromium.org changed reviewers:
+ thakis@chromium.org
- tsepez@chromium.org

[Bo Xu, 2014-12-19 20:16:51]

bo_xu@foxitsoftware.com changed reviewers:
+ tsepez@chromium.org
- thakis@chromium.org

[Lei Zhang, 2014-12-19 20:19:12]

https://codereview.chromium.org/815103002/diff/10001/BUILD.gn
File BUILD.gn (right):

https://codereview.chromium.org/815103002/diff/10001/BUILD.gn#newcode94
BUILD.gn:94: "third_party:safemath",
nit: put these in alphabetical order? same with gyp file.

https://codereview.chromium.org/815103002/diff/10001/third_party/BUILD.gn
File third_party/BUILD.gn (right):

https://codereview.chromium.org/815103002/diff/10001/third_party/BUILD.gn#new...
third_party/BUILD.gn:7: ":third_party",
Is this a circular dependency?

https://codereview.chromium.org/815103002/diff/10001/third_party/BUILD.gn#new...
third_party/BUILD.gn:55: "freetype/src/cff/cffobjs.h",
funny indentation

https://codereview.chromium.org/815103002/diff/10001/third_party/third_party.gyp
File third_party/third_party.gyp (right):

https://codereview.chromium.org/815103002/diff/10001/third_party/third_party....
third_party/third_party.gyp:36: {
nit: funny indentation

[Bo Xu, 2014-12-19 22:16:36]

On 2014/12/19 20:10:00, Tom Sepez wrote:
> On 2014/12/19 19:34:36, Bo Xu wrote:
> > Hi Tom and Lei, please review this CL. I am not quite sure of what I am
doing
> on
> > the BUILD.gn file, so please suggest on anything bad there.
> 
> The first thing to do is to check that your GN build works.  I usually do this
> in a parallel build directory:
> 
> $ gn gen out_gn/Default
> $ ninja -C out_gn/Default pdfium_test chrome
> 
> Can you try this after applying your patch?

I tried the above on Patch #3 and it works.

[Bo Xu, 2014-12-19 22:16:57]

https://codereview.chromium.org/815103002/diff/10001/BUILD.gn
File BUILD.gn (right):

https://codereview.chromium.org/815103002/diff/10001/BUILD.gn#newcode94
BUILD.gn:94: "third_party:safemath",
On 2014/12/19 20:19:12, Lei Zhang wrote:
> nit: put these in alphabetical order? same with gyp file.

Done.

https://codereview.chromium.org/815103002/diff/10001/third_party/BUILD.gn
File third_party/BUILD.gn (right):

https://codereview.chromium.org/815103002/diff/10001/third_party/BUILD.gn#new...
third_party/BUILD.gn:55: "freetype/src/cff/cffobjs.h",
On 2014/12/19 20:19:12, Lei Zhang wrote:
> funny indentation

Done.

https://codereview.chromium.org/815103002/diff/10001/third_party/third_party.gyp
File third_party/third_party.gyp (right):

https://codereview.chromium.org/815103002/diff/10001/third_party/third_party....
third_party/third_party.gyp:36: {
On 2014/12/19 20:19:12, Lei Zhang wrote:
> nit: funny indentation

Done.

[Tom Sepez, 2014-12-19 22:18:12]

Looks Good, but wait for approval from Lei.

[Lei Zhang, 2014-12-19 22:26:20]

lgtm

[Bo Xu, 2014-12-19 22:30:10]

Committed patchset #3 (id:20001) manually as
e4fc5ced45c8fcfbe2487ec64eab036bc7d57602 (presubmit successful).

[Bo Xu, 2015-01-09 00:39:23]

On 2014/12/19 20:10:00, Tom Sepez wrote:
> On 2014/12/19 19:34:36, Bo Xu wrote:
> > Hi Tom and Lei, please review this CL. I am not quite sure of what I am
doing
> on
> > the BUILD.gn file, so please suggest on anything bad there.
> 
> The first thing to do is to check that your GN build works.  I usually do this
> in a parallel build directory:
> 
> $ gn gen out_gn/Default
> $ ninja -C out_gn/Default pdfium_test chrome
> 
> Can you try this after applying your patch?

Tom, I am trying gn on xfa branch, get following error, but not seeing them in
master branch. Wonder do you see the same thing?

ninja: Entering directory `out_gn/Default/'
[13/140] CC
obj/third_party/pdfium/third_party/freetype/src/base/libfreetype.ftbase.o
FAILED: ../../third_party/llvm-build/Release+Asserts/bin/clang -MMD -MF
obj/third_party/pdfium/third_party/freetype/src/base/libfreetype.ftbase.o.d
-DFT2_BUILD_LIBRARY -DCHROMIUM_BUILD -DV8_DEPRECATION_WARNINGS -DCLD_VERSION=2
-DENABLE_MDNS=1 -DENABLE_NOTIFICATIONS -DENABLE_PEPPER_CDMS -DENABLE_PLUGINS=1
-DENABLE_PRINTING=1 -DENABLE_BASIC_PRINTING=1 -DENABLE_PRINT_PREVIEW=1
-DENABLE_SPELLCHECK=1 -DUSE_UDEV -DTOOLKIT_VIEWS=1
-DUI_COMPOSITOR_IMAGE_TRANSPORT -DUSE_ASH=1 -DUSE_AURA=1 -DUSE_PANGO=1
-DUSE_CAIRO=1 -DUSE_CLIPBOARD_AURAX11=1 -DUSE_DEFAULT_RENDER_THEME=1
-DUSE_GLIB=1 -DUSE_NSS=1 -DUSE_X11=1 -DDISABLE_NACL -DENABLE_EXTENSIONS=1
-DENABLE_CONFIGURATION_POLICY -DENABLE_TASK_MANAGER=1 -DENABLE_THEMES=1
-DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_SESSION_SERVICE=1
-DENABLE_APP_LIST=1 -DENABLE_SETTINGS_APP=1 -DENABLE_SUPERVISED_USERS=1
-DENABLE_SERVICE_DISCOVERY=1 -DENABLE_AUTOFILL_DIALOG=1 -DENABLE_REMOTING=1
-DENABLE_GOOGLE_NOW=1 -DENABLE_ONE_CLICK_SIGNIN -DV8_USE_EXTERNAL_STARTUP_DATA
-DCR_CLANG_REVISION=223108 -D_FILE_OFFSET_BITS=64 -D__STDC_CONSTANT_MACROS
-D__STDC_FORMAT_MACROS -D_DEBUG -DDYNAMIC_ANNOTATIONS_ENABLED=1
-DWTF_USE_DYNAMIC_ANNOTATIONS=1 -D_GLIBCXX_DEBUG=1
-I../../third_party/pdfium/third_party/freetype/include -I../.. -Igen
-fno-strict-aliasing -fstack-protector --param=ssp-buffer-size=4 -m64
-march=x86-64 -funwind-tables -fPIC -pipe -pthread
-B../../third_party/binutils/Linux_x64/Release/bin -fcolor-diagnostics -Wall
-Wsign-compare -Wendif-labels -Werror -Wno-missing-field-initializers
-Wno-unused-parameter -Wno-c++11-narrowing -Wno-char-subscripts
-Wno-covered-switch-default -Wno-deprecated-register
-Wno-unneeded-internal-declaration -Wno-reserved-user-defined-literal
-Wno-inconsistent-missing-override -fvisibility=hidden -Xclang -load -Xclang
../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so -Xclang
-add-plugin -Xclang find-bad-constructs -Wheader-hygiene -Wstring-conversion -O0
-g2 -gsplit-dwarf  -c
../../third_party/pdfium/third_party/freetype/src/base/ftbase.c -o
obj/third_party/pdfium/third_party/freetype/src/base/libfreetype.ftbase.o
In file included from
../../third_party/pdfium/third_party/freetype/src/base/ftbase.c:31:
In file included from
../../third_party/pdfium/third_party/freetype/src/base/ftrfork.c:32:
../../third_party/pdfium/third_party/freetype/src/base/ftbase.h:33:3: error:
unused function 'open_face_PS_from_sfnt_stream' [-Werror,-Wunused-function]
  open_face_PS_from_sfnt_stream( FT_Library     library,
  ^
../../third_party/pdfium/third_party/freetype/src/base/ftbase.h:44:3: error:
unused function 'open_face_from_buffer' [-Werror,-Wunused-function]
  open_face_from_buffer( FT_Library   library,
  ^
2 errors generated.

[Tom Sepez, 2015-01-09 19:54:23]

The compiler switches used by gn and gyp builds can be different, because the
input files .gn and .gyp are different.  It looks like in the .gn case we've
picked up a -Werror flag for the freetype directory that isn't present in the
.gyp build, which turns all warnings into errors. Most third_party code won't
build under such strict conditions, so its probably OK to remove that for that
third_party directory only -- given that its unmodified. 

So either the new freetype has warnings where the old one didn't, or freetype
has always had warnings but
the -Werror switch got added where it wasn't present before.  It would be nice
to figure out which one it was.

[Tom Sepez, 2015-01-09 20:02:28]

Ah, looks like you need to add to your new build.gn the same code as at line
640:

640   configs -= [ "//build/config/compiler:chromium_code" ]
641   configs += [ ":pdfium_config", "//build/config/compiler:no_chromium_code"
]

But the pdfium_config target is now in a different build.gn so it needs a proper
path.

[Tom Sepez, 2015-01-09 22:09:15]

I'll put together a patch for this.

[Bo Xu, 2015-01-09 22:12:09]

On 2015/01/09 22:09:15, Tom Sepez wrote:
> I'll put together a patch for this.

That's great! I am looking at your patch of unittest and trying to mimic that
but would be great if you can do it.