Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 806993002: Removed deprecated navigator.webkitGetGamepads. (Closed)

Created:
6 years ago by bajones
Modified:
6 years ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Removed deprecated navigator.webkitGetGamepads. Feature has been deprecated since M35. Use navigator.getGamepads instead. BUG=442556 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187406

Patch Set 1 #

Patch Set 2 : Oops. Forgot to add the LayoutTests dir changes #

Patch Set 3 : Missed one layout test expectations update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -412 lines) Patch
M LayoutTests/fast/dom/navigator-with-content-detached-no-crash-expected.txt View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/gamepad/gamepad-api.html View 1 2 chunks +10 lines, -34 lines 0 comments Download
M LayoutTests/gamepad/gamepad-api-expected.txt View 1 1 chunk +0 lines, -17 lines 0 comments Download
M LayoutTests/gamepad/gamepad-polling-access.html View 1 3 chunks +0 lines, -22 lines 0 comments Download
M LayoutTests/gamepad/gamepad-polling-access-expected.txt View 1 2 chunks +0 lines, -21 lines 0 comments Download
M LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/webexposed/global-interface-listing-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/frame/UseCounter.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/frame/UseCounter.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/modules/gamepad/Gamepad.h View 3 chunks +30 lines, -2 lines 0 comments Download
M Source/modules/gamepad/Gamepad.cpp View 2 chunks +9 lines, -0 lines 0 comments Download
D Source/modules/gamepad/GamepadCommon.h View 1 chunk +0 lines, -70 lines 0 comments Download
D Source/modules/gamepad/GamepadCommon.cpp View 1 chunk +0 lines, -48 lines 0 comments Download
M Source/modules/gamepad/NavigatorGamepad.h View 3 chunks +0 lines, -5 lines 0 comments Download
M Source/modules/gamepad/NavigatorGamepad.cpp View 4 chunks +1 line, -19 lines 0 comments Download
M Source/modules/gamepad/NavigatorGamepad.idl View 1 chunk +0 lines, -1 line 0 comments Download
D Source/modules/gamepad/WebKitGamepad.h View 1 chunk +0 lines, -38 lines 0 comments Download
D Source/modules/gamepad/WebKitGamepad.cpp View 1 chunk +0 lines, -25 lines 0 comments Download
D Source/modules/gamepad/WebKitGamepad.idl View 1 chunk +0 lines, -15 lines 0 comments Download
D Source/modules/gamepad/WebKitGamepadList.h View 1 chunk +0 lines, -36 lines 0 comments Download
D Source/modules/gamepad/WebKitGamepadList.cpp View 1 chunk +0 lines, -33 lines 0 comments Download
D Source/modules/gamepad/WebKitGamepadList.idl View 1 chunk +0 lines, -11 lines 0 comments Download
M Source/modules/modules.gypi View 3 chunks +0 lines, -8 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
bajones
Mind taking a quick look at this? Pretty straightforward removal of the deprecated stuff.
6 years ago (2014-12-16 00:49:33 UTC) #2
kbalazs
On 2014/12/16 00:49:33, bajones wrote: > Mind taking a quick look at this? Pretty straightforward ...
6 years ago (2014-12-16 18:32:41 UTC) #3
bajones
Thanks! kbr@: I need an owners review on the Source/core files. It's a simple enough ...
6 years ago (2014-12-16 22:11:09 UTC) #5
Ken Russell (switch to Gerrit)
LGTM - good cleanup.
6 years ago (2014-12-16 23:27:04 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/806993002/40001
6 years ago (2014-12-17 18:59:14 UTC) #8
commit-bot: I haz the power
6 years ago (2014-12-17 22:29:57 UTC) #9
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=187406

Powered by Google App Engine
This is Rietveld 408576698