nacl_io: accept now allows addr and len to be NULL

nacl_io: accept now allows addr and len to be NULL

BUG=442164
R=sbc@chromium.org

Committed: https://crrev.com/952ecaee95ff68a61f7fd7ee63eaa1a941a1d57e
Cr-Commit-Position: refs/heads/master@{#310512}

[Sam Clegg, 2014-12-24 13:09:35]

lgtm with comments.

Thanks for the fix!

https://codereview.chromium.org/804993008/diff/20001/AUTHORS
File AUTHORS (right):

https://codereview.chromium.org/804993008/diff/20001/AUTHORS#newcode104
AUTHORS:104: Daiwei Li <daiweili@suitabletech.com>
We have our own authors file in native_client_sdk/src which would probably be
more appropriate.

https://codereview.chromium.org/804993008/diff/20001/native_client_sdk/src/te...
File native_client_sdk/src/tests/nacl_io_socket_test/socket_test.cc (right):

https://codereview.chromium.org/804993008/diff/20001/native_client_sdk/src/te...
native_client_sdk/src/tests/nacl_io_socket_test/socket_test.cc:618: ASSERT_EQ(0,
 ki_listen(server_sock, 10));
Remove extra space.

https://codereview.chromium.org/804993008/diff/20001/native_client_sdk/src/te...
native_client_sdk/src/tests/nacl_io_socket_test/socket_test.cc:620: // Connect
to listening socket, and send greeting
Comment is inaccurate.

[daiweili, 2014-12-24 17:27:08]

Comment and spacing fixed locally. Just need a quick reply re: the AUTHORS file
and I can push another patch.

https://codereview.chromium.org/804993008/diff/20001/AUTHORS
File AUTHORS (right):

https://codereview.chromium.org/804993008/diff/20001/AUTHORS#newcode104
AUTHORS:104: Daiwei Li <daiweili@suitabletech.com>
On 2014/12/24 13:09:35, Sam Clegg wrote:
> We have our own authors file in native_client_sdk/src which would probably be
> more appropriate.

I tried adding myself there first but a pre-submit hook warned me and told me to
put my name here instead. Should I ignore that warning?

** Presubmit Warnings **
daiweili@suitabletech.com is not in AUTHORS file. If you are a new contributor,
please visit
http://www.chromium.org/developers/contributing-code and read the "Legal"
section
If you are a chromite, verify the contributor signed the CLA.

https://codereview.chromium.org/804993008/diff/20001/native_client_sdk/src/te...
File native_client_sdk/src/tests/nacl_io_socket_test/socket_test.cc (right):

https://codereview.chromium.org/804993008/diff/20001/native_client_sdk/src/te...
native_client_sdk/src/tests/nacl_io_socket_test/socket_test.cc:618: ASSERT_EQ(0,
 ki_listen(server_sock, 10));
On 2014/12/24 13:09:35, Sam Clegg wrote:
> Remove extra space.

Done.

https://codereview.chromium.org/804993008/diff/20001/native_client_sdk/src/te...
native_client_sdk/src/tests/nacl_io_socket_test/socket_test.cc:620: // Connect
to listening socket, and send greeting
On 2014/12/24 13:09:35, Sam Clegg wrote:
> Comment is inaccurate.

Done.

[Sam Clegg, 2015-01-02 14:08:57]

Can you run the trybots (git cl try)?

Also, you change the BUG= line in the description for simply BUG=<NUMBER>.

Otherwise lgtm.  Thanks.

https://codereview.chromium.org/804993008/diff/20001/AUTHORS
File AUTHORS (right):

https://codereview.chromium.org/804993008/diff/20001/AUTHORS#newcode104
AUTHORS:104: Daiwei Li <daiweili@suitabletech.com>
On 2014/12/24 17:27:07, daiweili wrote:
> On 2014/12/24 13:09:35, Sam Clegg wrote:
> > We have our own authors file in native_client_sdk/src which would probably
be
> > more appropriate.
> 
> I tried adding myself there first but a pre-submit hook warned me and told me
to
> put my name here instead. Should I ignore that warning?
> 
> ** Presubmit Warnings **
> mailto:daiweili@suitabletech.com is not in AUTHORS file. If you are a new
contributor,
> please visit
> http://www.chromium.org/developers/contributing-code and read the "Legal"
> section
> If you are a chromite, verify the contributor signed the CLA.

Ah, OK.  Perhaps best to add yourself to both.

[daiweili, 2015-01-02 22:11:41]

The CQ bit was checked by daiweili@suitabletech.com

[daiweili, 2015-01-02 22:11:42]

The CQ bit was unchecked by daiweili@suitabletech.com

[daiweili, 2015-01-02 22:18:12]

On 2015/01/02 14:08:57, Sam Clegg wrote:
> Can you run the trybots (git cl try)?
> 
> Also, you change the BUG= line in the description for simply BUG=<NUMBER>.
> 
> Otherwise lgtm.  Thanks.
> 
> https://codereview.chromium.org/804993008/diff/20001/AUTHORS
> File AUTHORS (right):
> 
> https://codereview.chromium.org/804993008/diff/20001/AUTHORS#newcode104
> AUTHORS:104: Daiwei Li <mailto:daiweili@suitabletech.com>
> On 2014/12/24 17:27:07, daiweili wrote:
> > On 2014/12/24 13:09:35, Sam Clegg wrote:
> > > We have our own authors file in native_client_sdk/src which would probably
> be
> > > more appropriate.
> > 
> > I tried adding myself there first but a pre-submit hook warned me and told
me
> to
> > put my name here instead. Should I ignore that warning?
> > 
> > ** Presubmit Warnings **
> > mailto:daiweili@suitabletech.com is not in AUTHORS file. If you are a new
> contributor,
> > please visit
> > http://www.chromium.org/developers/contributing-code and read the "Legal"
> > section
> > If you are a chromite, verify the contributor signed the CLA.
> 
> Ah, OK.  Perhaps best to add yourself to both.

Ok. I ran git cl try. I suppose the results will be re-added to this ticket when
they're done running?

I edited the BUG= with git commit --amend and cl uploaded that but I don't see
it being changed here.

[daiweili, 2015-01-02 22:18:24]

https://codereview.chromium.org/804993008/diff/20001/AUTHORS
File AUTHORS (right):

https://codereview.chromium.org/804993008/diff/20001/AUTHORS#newcode104
AUTHORS:104: Daiwei Li <daiweili@suitabletech.com>
On 2015/01/02 14:08:57, Sam Clegg wrote:
> On 2014/12/24 17:27:07, daiweili wrote:
> > On 2014/12/24 13:09:35, Sam Clegg wrote:
> > > We have our own authors file in native_client_sdk/src which would probably
> be
> > > more appropriate.
> > 
> > I tried adding myself there first but a pre-submit hook warned me and told
me
> to
> > put my name here instead. Should I ignore that warning?
> > 
> > ** Presubmit Warnings **
> > mailto:daiweili@suitabletech.com is not in AUTHORS file. If you are a new
> contributor,
> > please visit
> > http://www.chromium.org/developers/contributing-code and read the "Legal"
> > section
> > If you are a chromite, verify the contributor signed the CLA.
> 
> Ah, OK.  Perhaps best to add yourself to both.

Done.

[Sam Clegg, 2015-01-03 10:41:21]

On 2015/01/02 22:18:12, daiweili wrote:
> On 2015/01/02 14:08:57, Sam Clegg wrote:
> > Can you run the trybots (git cl try)?
> > 
> > Also, you change the BUG= line in the description for simply BUG=<NUMBER>.
> > 
> > Otherwise lgtm.  Thanks.
> > 
> > https://codereview.chromium.org/804993008/diff/20001/AUTHORS
> > File AUTHORS (right):
> > 
> > https://codereview.chromium.org/804993008/diff/20001/AUTHORS#newcode104
> > AUTHORS:104: Daiwei Li <mailto:daiweili@suitabletech.com>
> > On 2014/12/24 17:27:07, daiweili wrote:
> > > On 2014/12/24 13:09:35, Sam Clegg wrote:
> > > > We have our own authors file in native_client_sdk/src which would
probably
> > be
> > > > more appropriate.
> > > 
> > > I tried adding myself there first but a pre-submit hook warned me and told
> me
> > to
> > > put my name here instead. Should I ignore that warning?
> > > 
> > > ** Presubmit Warnings **
> > > mailto:daiweili@suitabletech.com is not in AUTHORS file. If you are a new
> > contributor,
> > > please visit
> > > http://www.chromium.org/developers/contributing-code and read the "Legal"
> > > section
> > > If you are a chromite, verify the contributor signed the CLA.
> > 
> > Ah, OK.  Perhaps best to add yourself to both.
> 
> Ok. I ran git cl try. I suppose the results will be re-added to this ticket
when
> they're done running?
> 
> I edited the BUG= with git commit --amend and cl uploaded that but I don't see
> it being changed here.

You can edit the description via the code review website.

[daiweili, 2015-01-03 10:49:08]

On 2015/01/03 10:41:21, Sam Clegg wrote:
> On 2015/01/02 22:18:12, daiweili wrote:
> > On 2015/01/02 14:08:57, Sam Clegg wrote:
> > > Can you run the trybots (git cl try)?
> > > 
> > > Also, you change the BUG= line in the description for simply BUG=<NUMBER>.
> > > 
> > > Otherwise lgtm.  Thanks.
> > > 
> > > https://codereview.chromium.org/804993008/diff/20001/AUTHORS
> > > File AUTHORS (right):
> > > 
> > > https://codereview.chromium.org/804993008/diff/20001/AUTHORS#newcode104
> > > AUTHORS:104: Daiwei Li <mailto:daiweili@suitabletech.com>
> > > On 2014/12/24 17:27:07, daiweili wrote:
> > > > On 2014/12/24 13:09:35, Sam Clegg wrote:
> > > > > We have our own authors file in native_client_sdk/src which would
> probably
> > > be
> > > > > more appropriate.
> > > > 
> > > > I tried adding myself there first but a pre-submit hook warned me and
told
> > me
> > > to
> > > > put my name here instead. Should I ignore that warning?
> > > > 
> > > > ** Presubmit Warnings **
> > > > mailto:daiweili@suitabletech.com is not in AUTHORS file. If you are a
new
> > > contributor,
> > > > please visit
> > > > http://www.chromium.org/developers/contributing-code and read the
"Legal"
> > > > section
> > > > If you are a chromite, verify the contributor signed the CLA.
> > > 
> > > Ah, OK.  Perhaps best to add yourself to both.
> > 
> > Ok. I ran git cl try. I suppose the results will be re-added to this ticket
> when
> > they're done running?
> > 
> > I edited the BUG= with git commit --amend and cl uploaded that but I don't
see
> > it being changed here.
> 
> You can edit the description via the code review website.

Ah, got it, thanks! It's been edited.

[daiweili, 2015-01-07 21:56:41]

I think someone needs to run git cl try for me.

[Sam Clegg, 2015-01-08 10:16:11]

On 2015/01/07 21:56:41, daiweili wrote:
> I think someone needs to run git cl try for me.

All looks good. You should be able to commit via the CQ now.

[daiweili, 2015-01-08 16:14:44]

The CQ bit was checked by daiweili@suitabletech.com

[commit-bot: I haz the power, 2015-01-08 16:15:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/804993008/60001

[commit-bot: I haz the power, 2015-01-08 16:17:32]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-01-08 16:18:14]

Patchset 4 (id:??) landed as
https://crrev.com/952ecaee95ff68a61f7fd7ee63eaa1a941a1d57e
Cr-Commit-Position: refs/heads/master@{#310512}