native_client_sdk/src/libraries/nacl_io/kernel_proxy.cc - Issue 804993008: nacl_io: accept now allows addr and len to be NULL

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: native_client_sdk/src/libraries/nacl_io/kernel_proxy.cc

Issue 804993008: nacl_io: accept now allows addr and len to be NULL (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove incorrect tests Created 5 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: native_client_sdk/src/libraries/nacl_io/kernel_proxy.cc

diff --git a/native_client_sdk/src/libraries/nacl_io/kernel_proxy.cc b/native_client_sdk/src/libraries/nacl_io/kernel_proxy.cc

index edaa202a1f1d58f7f7811581090b449955da3d3f..c7d721c77a45995408c21fc9fe61e372653022ba 100644

--- a/native_client_sdk/src/libraries/nacl_io/kernel_proxy.cc

+++ b/native_client_sdk/src/libraries/nacl_io/kernel_proxy.cc

@@ -1362,11 +1362,6 @@ int KernelProxy::poll(struct pollfd* fds, nfds_t nfds, int timeout) {

// Socket Functions

int KernelProxy::accept(int fd, struct sockaddr* addr, socklen_t* len) {

- if (NULL == addr || NULL == len) {

- errno = EFAULT;

- return -1;

- }

ScopedKernelHandle handle;

Error error = AcquireHandle(fd, &handle);

if (error) {