native_client_sdk/src/libraries/nacl_io/socket/tcp_node.cc - Issue 804993008: nacl_io: accept now allows addr and len to be NULL

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: native_client_sdk/src/libraries/nacl_io/socket/tcp_node.cc

Issue 804993008: nacl_io: accept now allows addr and len to be NULL (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove incorrect tests Created 5 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: native_client_sdk/src/libraries/nacl_io/socket/tcp_node.cc

diff --git a/native_client_sdk/src/libraries/nacl_io/socket/tcp_node.cc b/native_client_sdk/src/libraries/nacl_io/socket/tcp_node.cc

index 69f657805b53de036c623cbddf58e17bd89ee2f6..738206eb730992f3c8c0fbbaa8437742c0523ebb 100644

--- a/native_client_sdk/src/libraries/nacl_io/socket/tcp_node.cc

+++ b/native_client_sdk/src/libraries/nacl_io/socket/tcp_node.cc

@@ -453,9 +453,11 @@ Error TcpNode::Accept(const HandleAttr& attr,

emitter_->ClearEvents_Locked(POLLIN);

// Set the out paramaters

- PP_Resource remote_addr = TCPInterface()->GetRemoteAddress(*out_sock);

- *len = ResourceToSockAddr(remote_addr, *len, addr);

- filesystem_->ppapi()->ReleaseResource(remote_addr);

+ if (addr && len) {

+ PP_Resource remote_addr = TCPInterface()->GetRemoteAddress(*out_sock);

+ *len = ResourceToSockAddr(remote_addr, *len, addr);

+ filesystem_->ppapi()->ReleaseResource(remote_addr);

+ }

QueueAccept();

return 0;