nacl_io: accept now allows addr and len to be NULL

native_client_sdk/src/tests/nacl_io_socket_test/socket_test.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <arpa/inet.h>
 #include <errno.h>
 #include <fcntl.h>
 #include <netinet/in.h>
 #include <pthread.h>
 #include <sys/types.h>
@@ skipping 590 matching lines @@
   ASSERT_EQ(0, Bind(sock1_, LOCAL_HOST, ANY_PORT));
 
   // Modify the test to verify the change by calling getsockopt
   // once UDPInterface supports GetOption() call
   ASSERT_EQ(0, ki_setsockopt(sock1_, SOL_SOCKET, SO_RCVBUF, &option, len))
     << "failed with: " << strerror(errno);
   ASSERT_EQ(0, ki_setsockopt(sock1_, SOL_SOCKET, SO_SNDBUF, &option, len))
     << "failed with: " << strerror(errno);
 }
 
+TEST_F(SocketTestTCP, AcceptNoParams) {
+  sockaddr_in addr;
+  socklen_t addrlen = sizeof(addr);
+  int server_sock = sock1_;
+
+  // Bind and Listen
+  ASSERT_EQ(0, Bind(server_sock, LOCAL_HOST, PORT1));
+  ASSERT_EQ(0,  ki_listen(server_sock, 10));

[Sam Clegg, 2014/12/24 13:09:35]

Remove extra space.

[daiweili, 2014/12/24 17:27:08]

Done.

+
+  // Connect to listening socket, and send greeting

[Sam Clegg, 2014/12/24 13:09:35]

Comment is inaccurate.

[daiweili, 2014/12/24 17:27:08]

Done.

+  int client_sock = sock2_;
+  IP4ToSockAddr(LOCAL_HOST, PORT1, &addr);
+  addrlen = sizeof(addr);
+  ASSERT_EQ(0, ki_connect(client_sock, (sockaddr*)&addr, addrlen))
+    << "Failed with " << errno << ": " << strerror(errno);
+
+  // Accept without addr and len should succeed
+  int new_socket = ki_accept(server_sock, NULL, NULL);
+  ASSERT_GT(new_socket, -1);
+
+  ASSERT_EQ(0, ki_close(new_socket));
+}
+
 TEST_F(SocketTestTCP, Listen) {
   sockaddr_in addr;
   socklen_t addrlen = sizeof(addr);
   const char* client_greeting = "hello";
   const char* server_reply = "reply";
   const int greeting_len = strlen(client_greeting);
   const int reply_len = strlen(server_reply);
 
   int server_sock = sock1_;
 
@@ skipping 275 matching lines @@
 
   // Modify the test to verify the change by calling getsockopt
   // once TCPInterface supports GetOption() call
   ASSERT_EQ(0, ki_setsockopt(sock2_, SOL_SOCKET, SO_RCVBUF, &option, len))
       << "failed with: " << strerror(errno);
   ASSERT_EQ(0, ki_setsockopt(sock2_, SOL_SOCKET, SO_SNDBUF, &option, len))
       << "failed with: " << strerror(errno);
 }
 
 #endif  // PROVIDES_SOCKET_API