Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(962)

Unified Diff: native_client_sdk/src/tests/nacl_io_test/socket_test.cc

Issue 804993008: nacl_io: accept now allows addr and len to be NULL (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove incorrect tests Created 5 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « native_client_sdk/src/tests/nacl_io_socket_test/socket_test.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: native_client_sdk/src/tests/nacl_io_test/socket_test.cc
diff --git a/native_client_sdk/src/tests/nacl_io_test/socket_test.cc b/native_client_sdk/src/tests/nacl_io_test/socket_test.cc
index 0947e391bbe5530ea0a7fc6b61ce0ca9b6cc6716..03d96375685ebef522042067da42e2b07fa74c6d 100644
--- a/native_client_sdk/src/tests/nacl_io_test/socket_test.cc
+++ b/native_client_sdk/src/tests/nacl_io_test/socket_test.cc
@@ -50,12 +50,14 @@ TEST_F(SocketTest, Accept) {
struct sockaddr addr = {};
socklen_t len = 0;
- EXPECT_LT(ki_accept(123, NULL, &len), 0);
- EXPECT_EQ(errno, EFAULT);
- EXPECT_LT(ki_accept(123, &addr, NULL), 0);
- EXPECT_EQ(errno, EFAULT);
- EXPECT_LT(ki_accept(123, NULL, NULL), 0);
- EXPECT_EQ(errno, EFAULT);
+ // accept() should allow NULL args for addr and len
+ // https://code.google.com/p/chromium/issues/detail?id=442164
+ // EXPECT_LT(ki_accept(123, NULL, &len), 0);
+ // EXPECT_EQ(errno, EFAULT);
+ // EXPECT_LT(ki_accept(123, &addr, NULL), 0);
+ // EXPECT_EQ(errno, EFAULT);
+ // EXPECT_LT(ki_accept(123, NULL, NULL), 0);
+ // EXPECT_EQ(errno, EFAULT);
EXPECT_LT(ki_accept(-1, &addr, &len), 0);
EXPECT_EQ(errno, EBADF);
EXPECT_LT(ki_accept(0, &addr, &len), 0);
« no previous file with comments | « native_client_sdk/src/tests/nacl_io_socket_test/socket_test.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698