nacl_io: accept now allows addr and len to be NULL

native_client_sdk/src/tests/nacl_io_test/socket_test.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <arpa/inet.h>
 #include <errno.h>
 #include <fcntl.h>
 #include <netinet/in.h>
 #include <pthread.h>
 #include <sys/types.h>
@@ skipping 32 matching lines @@
  protected:
   KernelProxy kp_;
 };
 
 }  // namespace
 
 TEST_F(SocketTest, Accept) {
   struct sockaddr addr = {};
   socklen_t len = 0;
 
-  EXPECT_LT(ki_accept(123, NULL, &len), 0);
-  EXPECT_EQ(errno, EFAULT);
-  EXPECT_LT(ki_accept(123, &addr, NULL), 0);
-  EXPECT_EQ(errno, EFAULT);
-  EXPECT_LT(ki_accept(123, NULL, NULL), 0);
-  EXPECT_EQ(errno, EFAULT);
+  // accept() should allow NULL args for addr and len
+  // https://code.google.com/p/chromium/issues/detail?id=442164
+  // EXPECT_LT(ki_accept(123, NULL, &len), 0);
+  // EXPECT_EQ(errno, EFAULT);
+  // EXPECT_LT(ki_accept(123, &addr, NULL), 0);
+  // EXPECT_EQ(errno, EFAULT);
+  // EXPECT_LT(ki_accept(123, NULL, NULL), 0);
+  // EXPECT_EQ(errno, EFAULT);
   EXPECT_LT(ki_accept(-1, &addr, &len), 0);
   EXPECT_EQ(errno, EBADF);
   EXPECT_LT(ki_accept(0, &addr, &len), 0);
   EXPECT_EQ(errno, ENOTSOCK);
 }
 
 TEST_F(SocketTest, Bind) {
   const struct sockaddr const_addr = {};
   socklen_t len = 0;
 
@@ skipping 459 matching lines @@
 
 TEST(SocketUtilityFunctions, Ntohl) {
   uint8_t network_bytes[4] = { 0x44, 0x33, 0x22, 0x11 };
   uint32_t network_long;
   memcpy(&network_long, network_bytes, 4);
   uint32_t host_long = ntohl(network_long);
   EXPECT_EQ(host_long, 0x44332211);
 }
 
 #endif  // PROVIDES_SOCKETPAIR_API