Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(482)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 797133003: Kill PageSet.AddPageWithDefaultRunNavigate. (Closed)

Created:
6 years ago by chrishenry
Modified:
6 years ago
Reviewers:
nednguyen
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Kill PageSet.AddPageWithDefaultRunNavigate. BUG=439512 Committed: https://crrev.com/61e3f05639540e1b692e8208b2c9be0de02df48e Cr-Commit-Position: refs/heads/master@{#308275}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+152 lines, -105 lines) Patch
M tools/perf/benchmarks/blink_perf.py View 2 chunks +2 lines, -1 line 0 comments Download
M tools/perf/benchmarks/dom_perf.py View 2 chunks +3 lines, -2 lines 0 comments Download
M tools/perf/benchmarks/dromaeo.py View 2 chunks +2 lines, -1 line 0 comments Download
M tools/perf/benchmarks/indexeddb_perf.py View 2 chunks +2 lines, -1 line 0 comments Download
M tools/perf/benchmarks/jetstream.py View 2 chunks +3 lines, -1 line 0 comments Download
M tools/perf/benchmarks/kraken.py View 2 chunks +4 lines, -2 lines 0 comments Download
M tools/perf/benchmarks/octane.py View 2 chunks +4 lines, -2 lines 0 comments Download
M tools/perf/benchmarks/robohornet_pro.py View 2 chunks +4 lines, -2 lines 0 comments Download
M tools/perf/benchmarks/spaceport.py View 2 chunks +2 lines, -1 line 0 comments Download
M tools/perf/benchmarks/speedometer.py View 2 chunks +3 lines, -1 line 0 comments Download
M tools/perf/benchmarks/sunspider.py View 2 chunks +6 lines, -5 lines 0 comments Download
M tools/telemetry/telemetry/page/page_set.py View 1 chunk +0 lines, -7 lines 0 comments Download
M tools/telemetry/telemetry/page/page_set_unittest.py View 1 chunk +3 lines, -3 lines 0 comments Download
M tools/telemetry/telemetry/page/page_unittest.py View 2 chunks +23 lines, -17 lines 0 comments Download
M tools/telemetry/telemetry/results/buildbot_output_formatter_unittest.py View 2 chunks +4 lines, -3 lines 0 comments Download
M tools/telemetry/telemetry/results/chart_json_output_formatter_unittest.py View 2 chunks +3 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/results/csv_output_formatter_unittest.py View 2 chunks +3 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/results/csv_pivot_table_output_formatter_unittest.py View 2 chunks +3 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/results/gtest_progress_reporter_unittest.py View 2 chunks +5 lines, -4 lines 0 comments Download
M tools/telemetry/telemetry/results/html_output_formatter_unittest.py View 2 chunks +4 lines, -3 lines 0 comments Download
M tools/telemetry/telemetry/results/json_output_formatter_unittest.py View 2 chunks +3 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/results/page_run_unittest.py View 2 chunks +3 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/results/page_test_results_unittest.py View 2 chunks +6 lines, -4 lines 0 comments Download
M tools/telemetry/telemetry/value/failure_unittest.py View 2 chunks +3 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/value/histogram_unittest.py View 2 chunks +6 lines, -4 lines 0 comments Download
M tools/telemetry/telemetry/value/list_of_scalar_values_unittest.py View 2 chunks +6 lines, -4 lines 0 comments Download
M tools/telemetry/telemetry/value/list_of_string_values_unittest.py View 2 chunks +6 lines, -4 lines 0 comments Download
M tools/telemetry/telemetry/value/merge_values_unittest.py View 2 chunks +6 lines, -4 lines 0 comments Download
M tools/telemetry/telemetry/value/scalar_unittest.py View 2 chunks +6 lines, -4 lines 0 comments Download
M tools/telemetry/telemetry/value/skip_unittest.py View 2 chunks +4 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/value/string_unittest.py View 2 chunks +6 lines, -4 lines 0 comments Download
M tools/telemetry/telemetry/value/trace_unittest.py View 2 chunks +6 lines, -4 lines 0 comments Download
M tools/telemetry/telemetry/value/value_unittest.py View 1 chunk +6 lines, -4 lines 0 comments Download
M tools/telemetry/telemetry/web_perf/timeline_based_measurement_unittest.py View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
chrishenry
6 years ago (2014-12-13 10:08:43 UTC) #2
nednguyen
lgtm
6 years ago (2014-12-13 15:39:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/797133003/1
6 years ago (2014-12-13 15:40:35 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-13 16:47:25 UTC) #6
commit-bot: I haz the power
6 years ago (2014-12-13 16:48:08 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/61e3f05639540e1b692e8208b2c9be0de02df48e
Cr-Commit-Position: refs/heads/master@{#308275}

Powered by Google App Engine
This is Rietveld 408576698