tools/telemetry/telemetry/web_perf/timeline_based_measurement_unittest.py - Issue 797133003: Kill PageSet.AddPageWithDefaultRunNavigate.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/web_perf/timeline_based_measurement_unittest.py

Issue 797133003: Kill PageSet.AddPageWithDefaultRunNavigate. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/telemetry/telemetry/web_perf/timeline_based_measurement_unittest.py

diff --git a/tools/telemetry/telemetry/web_perf/timeline_based_measurement_unittest.py b/tools/telemetry/telemetry/web_perf/timeline_based_measurement_unittest.py

index 022326c1295b1727eb3f58dc2248b04a3ce2671d..8155486208f7b5a852da10eed013ca30389c06b4 100644

--- a/tools/telemetry/telemetry/web_perf/timeline_based_measurement_unittest.py

+++ b/tools/telemetry/telemetry/web_perf/timeline_based_measurement_unittest.py

@@ -92,7 +92,8 @@ class TimelineBasedMetricTestData(object):

self._metric = tbm_module._TimelineBasedMetrics( # pylint: disable=W0212

self._model, self._renderer_thread, GetMetricFromMetricType)

self._ps = page_set.PageSet(file_path=os.path.dirname(__file__))

- self._ps.AddPageWithDefaultRunNavigate('http://www.bar.com/')

+ self._ps.AddUserStory(page_module.Page(

+ 'http://www.bar.com/', self._ps, self._ps.base_dir))

self._results.WillRunPage(self._ps.pages[0])

def AddResults(self):

« no previous file with comments | « tools/telemetry/telemetry/value/value_unittest.py ('k') | no next file » | no next file with comments »