tools/telemetry/telemetry/results/chart_json_output_formatter_unittest.py - Issue 797133003: Kill PageSet.AddPageWithDefaultRunNavigate.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/results/chart_json_output_formatter_unittest.py

Issue 797133003: Kill PageSet.AddPageWithDefaultRunNavigate. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/results/buildbot_output_formatter_unittest.py ('k') | tools/telemetry/telemetry/results/csv_output_formatter_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/results/chart_json_output_formatter_unittest.py

diff --git a/tools/telemetry/telemetry/results/chart_json_output_formatter_unittest.py b/tools/telemetry/telemetry/results/chart_json_output_formatter_unittest.py

index 23a8b964f09060042455e817711e158291555aa6..87600cb8c1fa4c1dd326964b4629408d37311d47 100644

--- a/tools/telemetry/telemetry/results/chart_json_output_formatter_unittest.py

+++ b/tools/telemetry/telemetry/results/chart_json_output_formatter_unittest.py

@@ -8,6 +8,7 @@ import StringIO

import unittest

from telemetry import benchmark

+from telemetry import page as page_module

from telemetry.results import chart_json_output_formatter

from telemetry.results import page_test_results

from telemetry.page import page_set

@@ -17,8 +18,8 @@ from telemetry.value import list_of_scalar_values

def _MakePageSet():

ps = page_set.PageSet(file_path=os.path.dirname(__file__))

- ps.AddPageWithDefaultRunNavigate('http://www.foo.com/')

- ps.AddPageWithDefaultRunNavigate('http://www.bar.com/')

+ ps.AddUserStory(page_module.Page('http://www.foo.com/', ps, ps.base_dir))

+ ps.AddUserStory(page_module.Page('http://www.bar.com/', ps, ps.base_dir))

return ps

class ChartJsonTest(unittest.TestCase):