Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Side by Side Diff: tools/telemetry/telemetry/value/trace_unittest.py

Issue 797133003: Kill PageSet.AddPageWithDefaultRunNavigate. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import os 5 import os
6 import unittest 6 import unittest
7 import shutil 7 import shutil
8 import tempfile 8 import tempfile
9 9
10 from telemetry import page as page_module
10 from telemetry.page import page_set 11 from telemetry.page import page_set
11 from telemetry.timeline import tracing_timeline_data 12 from telemetry.timeline import tracing_timeline_data
12 from telemetry.unittest_util import system_stub 13 from telemetry.unittest_util import system_stub
13 from telemetry.util import file_handle 14 from telemetry.util import file_handle
14 from telemetry.value import trace 15 from telemetry.value import trace
15 16
16 17
17 class TestBase(unittest.TestCase): 18 class TestBase(unittest.TestCase):
18 19
19 def setUp(self): 20 def setUp(self):
20 self.page_set = page_set.PageSet(file_path=os.path.dirname(__file__)) 21 ps = page_set.PageSet(file_path=os.path.dirname(__file__))
21 self.page_set.AddPageWithDefaultRunNavigate('http://www.bar.com/') 22 ps.AddUserStory(page_module.Page('http://www.bar.com/', ps, ps.base_dir))
22 self.page_set.AddPageWithDefaultRunNavigate('http://www.baz.com/') 23 ps.AddUserStory(page_module.Page('http://www.baz.com/', ps, ps.base_dir))
23 self.page_set.AddPageWithDefaultRunNavigate('http://www.foo.com/') 24 ps.AddUserStory(page_module.Page('http://www.foo.com/', ps, ps.base_dir))
25 self.page_set = ps
24 26
25 self._cloud_storage_stub = system_stub.Override(trace, ['cloud_storage']) 27 self._cloud_storage_stub = system_stub.Override(trace, ['cloud_storage'])
26 28
27 def tearDown(self): 29 def tearDown(self):
28 if self._cloud_storage_stub: 30 if self._cloud_storage_stub:
29 self._cloud_storage_stub.Restore() 31 self._cloud_storage_stub.Restore()
30 self._cloud_storage_stub = None 32 self._cloud_storage_stub = None
31 33
32 @property 34 @property
33 def pages(self): 35 def pages(self):
(...skipping 90 matching lines...) Expand 10 before | Expand all | Expand 10 after
124 trace.cloud_storage.SetCalculatedHashesForTesting( 126 trace.cloud_storage.SetCalculatedHashesForTesting(
125 TestDefaultDict(123)) 127 TestDefaultDict(123))
126 bucket = trace.cloud_storage.PUBLIC_BUCKET 128 bucket = trace.cloud_storage.PUBLIC_BUCKET
127 v.UploadToCloud(bucket) 129 v.UploadToCloud(bucket)
128 self.assertTrue(_IsEmptyDir(self.temp_test_dir)) 130 self.assertTrue(_IsEmptyDir(self.temp_test_dir))
129 131
130 def tearDown(self): 132 def tearDown(self):
131 super(NoLeakedTempfilesTests, self).tearDown() 133 super(NoLeakedTempfilesTests, self).tearDown()
132 shutil.rmtree(self.temp_test_dir) 134 shutil.rmtree(self.temp_test_dir)
133 trace.tempfile.tempdir = self.actual_tempdir 135 trace.tempfile.tempdir = self.actual_tempdir
OLDNEW
« no previous file with comments | « tools/telemetry/telemetry/value/string_unittest.py ('k') | tools/telemetry/telemetry/value/value_unittest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698