tools/telemetry/telemetry/results/gtest_progress_reporter_unittest.py - Issue 797133003: Kill PageSet.AddPageWithDefaultRunNavigate.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/results/gtest_progress_reporter_unittest.py

Issue 797133003: Kill PageSet.AddPageWithDefaultRunNavigate. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/results/csv_pivot_table_output_formatter_unittest.py ('k') | tools/telemetry/telemetry/results/html_output_formatter_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/results/gtest_progress_reporter_unittest.py

diff --git a/tools/telemetry/telemetry/results/gtest_progress_reporter_unittest.py b/tools/telemetry/telemetry/results/gtest_progress_reporter_unittest.py

index fe38d7a9e29cc6099dd9aed05908c3d8147c24e6..9f0cef17643529c5f5deb3a78ed5113a78dbab27 100644

--- a/tools/telemetry/telemetry/results/gtest_progress_reporter_unittest.py

+++ b/tools/telemetry/telemetry/results/gtest_progress_reporter_unittest.py

@@ -5,6 +5,7 @@

import os

import traceback

+from telemetry import page as page_module

from telemetry.page import page_set

from telemetry.results import base_test_results_unittest

from telemetry.results import gtest_progress_reporter

@@ -16,10 +17,10 @@ from telemetry.value import skip

def _MakePageSet():

ps = page_set.PageSet(file_path=os.path.dirname(__file__))

- ps.AddPageWithDefaultRunNavigate('http://www.foo.com/')

- ps.AddPageWithDefaultRunNavigate('http://www.bar.com/')

- ps.AddPageWithDefaultRunNavigate('http://www.baz.com/')

- ps.AddPageWithDefaultRunNavigate('http://www.roz.com/')

+ ps.AddUserStory(page_module.Page('http://www.foo.com/', ps, ps.base_dir))

+ ps.AddUserStory(page_module.Page('http://www.bar.com/', ps, ps.base_dir))

+ ps.AddUserStory(page_module.Page('http://www.baz.com/', ps, ps.base_dir))

+ ps.AddUserStory(page_module.Page('http://www.roz.com/', ps, ps.base_dir))

return ps