Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Unified Diff: tools/telemetry/telemetry/value/string_unittest.py

Issue 797133003: Kill PageSet.AddPageWithDefaultRunNavigate. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/telemetry/telemetry/value/skip_unittest.py ('k') | tools/telemetry/telemetry/value/trace_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/value/string_unittest.py
diff --git a/tools/telemetry/telemetry/value/string_unittest.py b/tools/telemetry/telemetry/value/string_unittest.py
index f35f6ae7531c2d9661b0b4d0af6ee925214b38e6..f629ea0d7b246f06bcdc620752b474226f888b42 100644
--- a/tools/telemetry/telemetry/value/string_unittest.py
+++ b/tools/telemetry/telemetry/value/string_unittest.py
@@ -4,6 +4,7 @@
import os
import unittest
+from telemetry import page as page_module
from telemetry import value
from telemetry.page import page_set
from telemetry.value import none_values
@@ -12,10 +13,11 @@ from telemetry.value import string
class TestBase(unittest.TestCase):
def setUp(self):
- self.page_set = page_set.PageSet(file_path=os.path.dirname(__file__))
- self.page_set.AddPageWithDefaultRunNavigate("http://www.bar.com/")
- self.page_set.AddPageWithDefaultRunNavigate("http://www.baz.com/")
- self.page_set.AddPageWithDefaultRunNavigate("http://www.foo.com/")
+ ps = page_set.PageSet(file_path=os.path.dirname(__file__))
+ ps.AddUserStory(page_module.Page("http://www.bar.com/", ps, ps.base_dir))
+ ps.AddUserStory(page_module.Page("http://www.baz.com/", ps, ps.base_dir))
+ ps.AddUserStory(page_module.Page("http://www.foo.com/", ps, ps.base_dir))
+ self.page_set = ps
@property
def pages(self):
« no previous file with comments | « tools/telemetry/telemetry/value/skip_unittest.py ('k') | tools/telemetry/telemetry/value/trace_unittest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698