Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Issue 7942008: NaCl repo side changes to make crash reporting more reliable. (Closed)

Created:
9 years, 3 months ago by bsy
Modified:
9 years, 3 months ago
CC:
native-client-reviews_googlegroups.com
Visibility:
Public.

Description

NaCl repo side changes to make crash reporting more reliable. The Chrome repo side changes depend on this CL, and both has to be committed before the following tests can be re-enabled: run_inbrowser_crash_in_syscall_test run_inbrowser_untrusted_crash_test BUG= http://code.google.com/p/nativeclient/issues/detail?id=2234 TEST= existing, but not-yet re-enabled Committed: http://src.chromium.org/viewvc/native_client?view=rev&revision=6727

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+137 lines, -12 lines) Patch
M src/trusted/nonnacl_util/posix/sel_ldr_launcher_posix.cc View 2 chunks +17 lines, -0 lines 0 comments Download
M src/trusted/nonnacl_util/win/sel_ldr_launcher_win.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M src/trusted/reverse_service/reverse_service.h View 2 chunks +17 lines, -1 line 0 comments Download
M src/trusted/reverse_service/reverse_service.cc View 2 chunks +18 lines, -3 lines 0 comments Download
M src/trusted/reverse_service/reverse_socket.h View 1 chunk +5 lines, -0 lines 0 comments Download
M src/trusted/reverse_service/reverse_socket.cc View 3 chunks +10 lines, -3 lines 0 comments Download
M src/trusted/service_runtime/sel_ldr.h View 1 chunk +19 lines, -0 lines 0 comments Download
M src/trusted/service_runtime/sel_ldr.c View 3 chunks +13 lines, -0 lines 0 comments Download
M src/trusted/service_runtime/sel_main.c View 2 chunks +12 lines, -1 line 0 comments Download
M src/trusted/service_runtime/sel_main_chrome.c View 1 3 chunks +17 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
bsy
9 years, 3 months ago (2011-09-19 20:47:51 UTC) #1
sehr (please use chromium)
On 2011/09/19 20:47:51, bsy wrote: LGTM. Thanks for doing this.
9 years, 3 months ago (2011-09-19 20:56:58 UTC) #2
bsy
9 years, 3 months ago (2011-09-19 22:09:27 UTC) #3
thx.  r6727.

On Mon, Sep 19, 2011 at 1:56 PM, <sehr@google.com> wrote:

> On 2011/09/19 20:47:51, bsy wrote:
>
> LGTM.  Thanks for doing this.
>
>
>
http://codereview.chromium.**org/7942008/<http://codereview.chromium.org/7942...
>



-- 
bennet s yee
i usually don't capitalize due to mild tendonitis

-- 
You received this message because you are subscribed to the Google Groups
"Native-Client-Reviews" group.
To post to this group, send email to native-client-reviews@googlegroups.com.
To unsubscribe from this group, send email to
native-client-reviews+unsubscribe@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/native-client-reviews?hl=en.

Powered by Google App Engine
This is Rietveld 408576698