Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Unified Diff: src/trusted/nonnacl_util/win/sel_ldr_launcher_win.cc

Issue 7942008: NaCl repo side changes to make crash reporting more reliable. (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client/
Patch Set: '' Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/trusted/nonnacl_util/win/sel_ldr_launcher_win.cc
===================================================================
--- src/trusted/nonnacl_util/win/sel_ldr_launcher_win.cc (revision 6725)
+++ src/trusted/nonnacl_util/win/sel_ldr_launcher_win.cc (working copy)
@@ -26,6 +26,15 @@
SelLdrLauncher::~SelLdrLauncher() {
CloseHandlesAfterLaunch();
if (kInvalidHandle != child_process_) {
+ // Ensure child process (service runtime) is kaput. NB: we might
+ // close the command channel (or use the hard_shutdown RPC) rather
+ // than killing the process to allow the service runtime to do
+ // clean up, but the plugin should be responsible for that and we
+ // shouldn't introduce any timeout wait in a dtor. Currently,
+ // ServiceRuntime::Shutdown kills the subprocess before closing
+ // the command channel, so we aren't providing the opportunity for
+ // a more graceful shutdown.
+ KillChildProcess();
CloseHandle(child_process_);
}
if (kInvalidHandle != channel_) {
« no previous file with comments | « src/trusted/nonnacl_util/posix/sel_ldr_launcher_posix.cc ('k') | src/trusted/reverse_service/reverse_service.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698