NaCl repo side changes to make crash reporting more reliable.

src/trusted/service_runtime/sel_ldr.h

 /*
  * Copyright (c) 2011 The Native Client Authors. All rights reserved.
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 /*
  * NaCl Simple/secure ELF loader (NaCl SEL).
  *
  * This loader can only process NaCl object files as produced using
@@ skipping 535 matching lines @@
     void                            (*handler)(
         void                                   *handler_state,
         struct NaClThreadInterface             *thread_if,
         struct NaClDesc                        *new_conn),
     void                            *handler_state) NACL_WUR;
 
 NaClErrorCode NaClWaitForLoadModuleStatus(struct NaClApp *nap) NACL_WUR;
 
 NaClErrorCode NaClWaitForStartModuleCommand(struct NaClApp *nap) NACL_WUR;
 
+/*
+ * NaClBlockIfCommandChannelExists is used during error exit.  If
+ * there is a secure command channel, we sent an RPC reply with the
+ * reason that the nexe was rejected.  If we exit immediately, that
+ * reply may still be in-flight and the various channel closure (esp
+ * reverse channels, if those were set up) may be detected first by
+ * the controlling process on the other end of the command channel or
+ * reverse channel.  When channel closure wins the race against the
+ * RPC reply, it would result in a crash being reported, rather than
+ * the error code carried in the RPC reply.  We want to ensure that
+ * the RPC reply to get processed.  Instead of allowing the service
+ * runtime process to exit, we block the main thread and wait for the
+ * hard-shutdown on the command channel or command channel closure.
+ *
+ * If there is no command channel, NaClBlockIfCommandChannelExists
+ * just returns immediately.
+ */
+void NaClBlockIfCommandChannelExists(struct NaClApp *nap);
+
 void NaClFillMemoryRegionWithHalt(void *start, size_t size);
 
 void NaClFillTrampolineRegion(struct NaClApp *nap);
 
 void NaClFillEndOfTextRegion(struct NaClApp *nap);
 
 #if (NACL_ARCH(NACL_BUILD_ARCH) == NACL_x86 \
      && NACL_BUILD_SUBARCH == 32 && __PIC__)
 
 int NaClMakePcrelThunk(struct NaClApp *nap);
@@ skipping 58 matching lines @@
 
 void NaClVmHoleWaitToStartThread(struct NaClApp *nap);
 
 void NaClVmHoleThreadStackIsSafe(struct NaClApp *nap);
 
 void NaClGdbHook(struct NaClApp const *nap);
 
 EXTERN_C_END
 
 #endif  /* NATIVE_CLIENT_SRC_TRUSTED_SERVICE_RUNTIME_SEL_LDR_H_ */