NaCl repo side changes to make crash reporting more reliable.

src/trusted/reverse_service/reverse_service.h

+/* -*- c++ -*- */
 /*
  * Copyright (c) 2011 The Native Client Authors. All rights reserved.
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #ifndef NATIVE_CLIENT_SRC_TRUSTED_REVERSE_SERVICE_REVERSE_SERVICE_H_
 #define NATIVE_CLIENT_SRC_TRUSTED_REVERSE_SERVICE_REVERSE_SERVICE_H_
 
 #include <set>
@@ skipping 52 matching lines @@
 
 class ReverseService : public RefCountBase {
  public:
   ReverseService(nacl::DescWrapper* conn_cap, ReverseInterface* rif);
 
   // covariant impl of Ref()
   ReverseService* Ref() {  // down_cast
     return reinterpret_cast<ReverseService*>(RefCountBase::Ref());
   }
 
-  bool Start();
+  // Start starts the reverse service by initiating a connection on
+  // the conn_cap and spawning a service thread using the
+  // ReverseInterface rif, both provided in the ctor.
+  //
+  // If |crash_report| is true, then the ReportCrash virtual function
+  // will be invoked when the reverse channel is closed.  Typically
+  // this is needed only in one (the "primary" or "bootstrap")
+  // instance of the reverse service, since additional channels
+  // created are often used for and are under application program
+  // control, and the untrusted application should be able to close
+  // those channels without generating a false crash report.
+  bool Start(bool crash_report);
+
+  bool Start() {
+    return Start(true);
+  }
 
   void WaitForServiceThreadsToExit();
 
   void IncrThreadCount();
   void DecrThreadCount();
 
   ReverseInterface* reverse_interface() const { return reverse_interface_; }
 
  protected:
   ~ReverseService();
@@ skipping 10 matching lines @@
   static NaClSrpcHandlerDesc const handlers[];
 
   NaClMutex mu_;
   NaClCondVar cv_;
   uint32_t thread_count_;
 };
 
 }  // namespace nacl
 
 #endif