Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Unified Diff: src/trusted/reverse_service/reverse_service.h

Issue 7942008: NaCl repo side changes to make crash reporting more reliable. (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client/
Patch Set: '' Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/trusted/reverse_service/reverse_service.h
===================================================================
--- src/trusted/reverse_service/reverse_service.h (revision 6725)
+++ src/trusted/reverse_service/reverse_service.h (working copy)
@@ -1,3 +1,4 @@
+/* -*- c++ -*- */
/*
* Copyright (c) 2011 The Native Client Authors. All rights reserved.
* Use of this source code is governed by a BSD-style license that can be
@@ -70,8 +71,23 @@
return reinterpret_cast<ReverseService*>(RefCountBase::Ref());
}
- bool Start();
+ // Start starts the reverse service by initiating a connection on
+ // the conn_cap and spawning a service thread using the
+ // ReverseInterface rif, both provided in the ctor.
+ //
+ // If |crash_report| is true, then the ReportCrash virtual function
+ // will be invoked when the reverse channel is closed. Typically
+ // this is needed only in one (the "primary" or "bootstrap")
+ // instance of the reverse service, since additional channels
+ // created are often used for and are under application program
+ // control, and the untrusted application should be able to close
+ // those channels without generating a false crash report.
+ bool Start(bool crash_report);
+ bool Start() {
+ return Start(true);
+ }
+
void WaitForServiceThreadsToExit();
void IncrThreadCount();
« no previous file with comments | « src/trusted/nonnacl_util/win/sel_ldr_launcher_win.cc ('k') | src/trusted/reverse_service/reverse_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698