Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1032)

Unified Diff: src/trusted/service_runtime/sel_ldr.h

Issue 7942008: NaCl repo side changes to make crash reporting more reliable. (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client/
Patch Set: '' Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/trusted/reverse_service/reverse_socket.cc ('k') | src/trusted/service_runtime/sel_ldr.c » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/trusted/service_runtime/sel_ldr.h
===================================================================
--- src/trusted/service_runtime/sel_ldr.h (revision 6725)
+++ src/trusted/service_runtime/sel_ldr.h (working copy)
@@ -553,6 +553,25 @@
NaClErrorCode NaClWaitForStartModuleCommand(struct NaClApp *nap) NACL_WUR;
+/*
+ * NaClBlockIfCommandChannelExists is used during error exit. If
+ * there is a secure command channel, we sent an RPC reply with the
+ * reason that the nexe was rejected. If we exit immediately, that
+ * reply may still be in-flight and the various channel closure (esp
+ * reverse channels, if those were set up) may be detected first by
+ * the controlling process on the other end of the command channel or
+ * reverse channel. When channel closure wins the race against the
+ * RPC reply, it would result in a crash being reported, rather than
+ * the error code carried in the RPC reply. We want to ensure that
+ * the RPC reply to get processed. Instead of allowing the service
+ * runtime process to exit, we block the main thread and wait for the
+ * hard-shutdown on the command channel or command channel closure.
+ *
+ * If there is no command channel, NaClBlockIfCommandChannelExists
+ * just returns immediately.
+ */
+void NaClBlockIfCommandChannelExists(struct NaClApp *nap);
+
void NaClFillMemoryRegionWithHalt(void *start, size_t size);
void NaClFillTrampolineRegion(struct NaClApp *nap);
« no previous file with comments | « src/trusted/reverse_service/reverse_socket.cc ('k') | src/trusted/service_runtime/sel_ldr.c » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698