Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(515)

Issue 782033002: Remove startup_url from PageSet, we can now only specify startup_url on a Page. (Closed)

Created:
6 years ago by chrishenry
Modified:
6 years ago
Reviewers:
nednguyen, achuithb, slamm
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove startup_url from PageSet, we can now only specify startup_url on a Page. Also make startup_url immutable. BUG=439512 Committed: https://crrev.com/5a1a8edb923692c2075810955c867a4f941fb78e Cr-Commit-Position: refs/heads/master@{#307116}

Patch Set 1 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -13 lines) Patch
M tools/perf/measurements/startup.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/startup_pages.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/page/__init__.py View 3 chunks +6 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/page/page_set.py View 2 chunks +2 lines, -4 lines 0 comments Download
M tools/telemetry/telemetry/unittest_util/page_set_smoke_test.py View 2 chunks +4 lines, -4 lines 1 comment Download

Messages

Total messages: 11 (3 generated)
chrishenry
I'm a little surprised that there isn't more pages that use startup_url. Am I missing ...
6 years ago (2014-12-05 21:39:54 UTC) #3
nednguyen
On 2014/12/05 21:39:54, chrishenry wrote: > I'm a little surprised that there isn't more pages ...
6 years ago (2014-12-05 21:45:09 UTC) #4
nednguyen
lgtm
6 years ago (2014-12-05 21:46:23 UTC) #5
chrishenry
On 2014/12/05 21:45:09, nednguyen wrote: > On 2014/12/05 21:39:54, chrishenry wrote: > > I'm a ...
6 years ago (2014-12-05 21:51:35 UTC) #6
slamm
lgtm https://codereview.chromium.org/782033002/diff/20001/tools/telemetry/telemetry/unittest_util/page_set_smoke_test.py File tools/telemetry/telemetry/unittest_util/page_set_smoke_test.py (right): https://codereview.chromium.org/782033002/diff/20001/tools/telemetry/telemetry/unittest_util/page_set_smoke_test.py#newcode124 tools/telemetry/telemetry/unittest_util/page_set_smoke_test.py:124: msg=('page %s \'s startup_url field must have type ...
6 years ago (2014-12-05 22:24:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/782033002/20001
6 years ago (2014-12-05 22:46:44 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:20001)
6 years ago (2014-12-05 23:43:33 UTC) #10
commit-bot: I haz the power
6 years ago (2014-12-05 23:45:08 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5a1a8edb923692c2075810955c867a4f941fb78e
Cr-Commit-Position: refs/heads/master@{#307116}

Powered by Google App Engine
This is Rietveld 408576698