tools/perf/measurements/startup.py - Issue 782033002: Remove startup_url from PageSet, we can now only specify startup_url on a Page.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/measurements/startup.py

Issue 782033002: Remove startup_url from PageSet, we can now only specify startup_url on a Page. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/perf/measurements/startup.py

diff --git a/tools/perf/measurements/startup.py b/tools/perf/measurements/startup.py

index bc0617d593f6e07930fdcf87fba1d247b7a3b6ad..8b57a486469e6b8286276653b5fcfd92865b8592 100644

--- a/tools/perf/measurements/startup.py

+++ b/tools/perf/measurements/startup.py

@@ -46,7 +46,7 @@ class StartWithUrl(Startup):

has already cached much of Chromium's content. For warm tests, you should

repeat the page set to ensure it's cached.

- The startup URL is taken from the page set's startup_url. This

+ The startup URL is taken from the page's startup_url. This

allows the testing of multiple different URLs in a single benchmark.

"""

« no previous file with comments | « no previous file | tools/perf/page_sets/startup_pages.py » ('j') | tools/telemetry/telemetry/unittest_util/page_set_smoke_test.py » ('J')