Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Unified Diff: tools/telemetry/telemetry/page/__init__.py

Issue 782033002: Remove startup_url from PageSet, we can now only specify startup_url on a Page. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/page/__init__.py
diff --git a/tools/telemetry/telemetry/page/__init__.py b/tools/telemetry/telemetry/page/__init__.py
index 05849860e3f182259dff296fead12f39ff5ac0b8..ab95c2134d50df9d58e516a8b4ff7a4e1df3b1a3 100644
--- a/tools/telemetry/telemetry/page/__init__.py
+++ b/tools/telemetry/telemetry/page/__init__.py
@@ -24,7 +24,7 @@ def _UpdateCredentials(credentials_path):
class Page(user_story.UserStory):
def __init__(self, url, page_set=None, base_dir=None, name='',
- credentials_path=None, labels=None):
+ credentials_path=None, labels=None, startup_url=''):
super(Page, self).__init__(shared_page_state.SharedPageState, name, labels)
self._url = url
self._page_set = page_set
@@ -44,7 +44,7 @@ class Page(user_story.UserStory):
# These attributes can be set dynamically by the page.
self.synthetic_delays = dict()
- self.startup_url = page_set.startup_url if page_set else ''
+ self._startup_url = startup_url
self.credentials = None
self.skip_waits = False
self.script_to_evaluate_on_commit = None
@@ -54,6 +54,10 @@ class Page(user_story.UserStory):
def credentials_path(self):
return self._credentials_path
+ @property
+ def startup_url(self):
+ return self._startup_url
+
def _SchemeErrorCheck(self):
if not self._scheme:
raise ValueError('Must prepend the URL with scheme (e.g. file://)')

Powered by Google App Engine
This is Rietveld 408576698