tools/perf/measurements/startup.py - Issue 782033002: Remove startup_url from PageSet, we can now only specify startup_url on a Page.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tools/perf/measurements/startup.py

Issue 782033002: Remove startup_url from PageSet, we can now only specify startup_url on a Page. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | tools/perf/page_sets/startup_pages.py » ('j') | tools/telemetry/telemetry/unittest_util/page_set_smoke_test.py » ('J')

OLD	NEW
1 # Copyright 2013 The Chromium Authors. All rights reserved.	1 # Copyright 2013 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 from metrics import startup_metric	5 from metrics import startup_metric

6 from telemetry.page import page_test	6 from telemetry.page import page_test

7	7

8	8

9 class Startup(page_test.PageTest):	9 class Startup(page_test.PageTest):

10 """Performs a measurement of Chromium's startup performance.	10 """Performs a measurement of Chromium's startup performance.

(...skipping 28 matching lines...) Expand all Loading...
39	39

40	40

41 class StartWithUrl(Startup):	41 class StartWithUrl(Startup):

42 """Performs a measurement of Chromium's performance starting with a URL.	42 """Performs a measurement of Chromium's performance starting with a URL.

43	43

44 Uses cold start if cold==True, otherwise uses warm start. A cold start means	44 Uses cold start if cold==True, otherwise uses warm start. A cold start means

45 none of the Chromium files are in the disk cache. A warm start assumes the OS	45 none of the Chromium files are in the disk cache. A warm start assumes the OS

46 has already cached much of Chromium's content. For warm tests, you should	46 has already cached much of Chromium's content. For warm tests, you should

47 repeat the page set to ensure it's cached.	47 repeat the page set to ensure it's cached.

48	48

49 The startup URL is taken from the page set's startup_url. This	49 The startup URL is taken from the page's startup_url. This

50 allows the testing of multiple different URLs in a single benchmark.	50 allows the testing of multiple different URLs in a single benchmark.

51 """	51 """

52	52

53 def __init__(self, cold=False):	53 def __init__(self, cold=False):

54 super(StartWithUrl, self).__init__(cold=cold,	54 super(StartWithUrl, self).__init__(cold=cold,

55 action_name_to_run='RunNavigateSteps')	55 action_name_to_run='RunNavigateSteps')

OLD	NEW