Index: tools/telemetry/telemetry/unittest_util/page_set_smoke_test.py |
diff --git a/tools/telemetry/telemetry/unittest_util/page_set_smoke_test.py b/tools/telemetry/telemetry/unittest_util/page_set_smoke_test.py |
index e2f0a06b6fa1103800e6f6ac90db002d88adfbdd..c7e353ccc0c346d7df714ef3f70c7d30725b255b 100644 |
--- a/tools/telemetry/telemetry/unittest_util/page_set_smoke_test.py |
+++ b/tools/telemetry/telemetry/unittest_util/page_set_smoke_test.py |
@@ -104,10 +104,6 @@ class PageSetSmokeTest(unittest.TestCase): |
isinstance(page_set.make_javascript_deterministic, bool), |
msg='page_set\'s make_javascript_deterministic must have type bool') |
- self.assertTrue( |
- isinstance(page_set.startup_url, str), |
- msg='page_set\'s startup_url must have type string') |
- |
def CheckAttributesOfPageBasicAttributes(self, page): |
self.assertTrue(not hasattr(page, 'disabled')) |
self.assertTrue( |
@@ -123,6 +119,10 @@ class PageSetSmokeTest(unittest.TestCase): |
self.assertTrue( |
isinstance(page.labels, set), |
msg='page %s \'s labels field must have type set' % page.display_name) |
+ self.assertTrue( |
+ isinstance(page.startup_url, str), |
+ msg=('page %s \'s startup_url field must have type string' |
slamm
2014/12/05 22:24:29
BTW, self.assertIsInstance is available.
|
+ % page.display_name)) |
for l in page.labels: |
self.assertTrue( |
isinstance(l, str), |