Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Side by Side Diff: tools/perf/page_sets/startup_pages.py

Issue 782033002: Remove startup_url from PageSet, we can now only specify startup_url on a Page. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 from telemetry.page import page as page_module 4 from telemetry.page import page as page_module
5 from telemetry.page import page_set as page_set_module 5 from telemetry.page import page_set as page_set_module
6 6
7 7
8 class StartedPage(page_module.Page): 8 class StartedPage(page_module.Page):
9 9
10 def __init__(self, url, startup_url, page_set): 10 def __init__(self, url, startup_url, page_set):
11 super(StartedPage, self).__init__(url=url, page_set=page_set) 11 super(StartedPage, self).__init__(
12 url=url, page_set=page_set, startup_url=startup_url)
12 self.archive_data_file = 'data/startup_pages.json' 13 self.archive_data_file = 'data/startup_pages.json'
13 self.startup_url = startup_url
14 14
15 def RunNavigateSteps(self, action_runner): 15 def RunNavigateSteps(self, action_runner):
16 action_runner.Wait(10) 16 action_runner.Wait(10)
17 17
18 class StartupPagesPageSet(page_set_module.PageSet): 18 class StartupPagesPageSet(page_set_module.PageSet):
19 19
20 """ Pages for testing starting Chrome with a URL. 20 """ Pages for testing starting Chrome with a URL.
21 Note that this file can't be used with record_wpr, since record_wpr requires 21 Note that this file can't be used with record_wpr, since record_wpr requires
22 a true navigate step, which we do not want for startup testing. Instead use 22 a true navigate step, which we do not want for startup testing. Instead use
23 record_wpr startup_pages_record to record data for this test. 23 record_wpr startup_pages_record to record data for this test.
24 """ 24 """
25 25
26 def __init__(self): 26 def __init__(self):
27 super(StartupPagesPageSet, self).__init__( 27 super(StartupPagesPageSet, self).__init__(
28 archive_data_file='data/startup_pages.json', 28 archive_data_file='data/startup_pages.json',
29 bucket=page_set_module.PARTNER_BUCKET) 29 bucket=page_set_module.PARTNER_BUCKET)
30 30
31 # Typical page. 31 # Typical page.
32 self.AddPage(StartedPage('about:blank', 'about:blank', self)) 32 self.AddPage(StartedPage('about:blank', 'about:blank', self))
33 # Typical page. 33 # Typical page.
34 self.AddPage(StartedPage('http://bbc.co.uk', 'http://bbc.co.uk', self)) 34 self.AddPage(StartedPage('http://bbc.co.uk', 'http://bbc.co.uk', self))
35 # Horribly complex page - stress test! 35 # Horribly complex page - stress test!
36 self.AddPage(StartedPage('http://kapook.com', 'http://kapook.com', self)) 36 self.AddPage(StartedPage('http://kapook.com', 'http://kapook.com', self))
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698