Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 768183002: Revert of Remove SK_SUPPORT_LEGACY_DEEPFLATTENING. (Closed)

Created:
6 years ago by mtklein
Modified:
6 years ago
Reviewers:
mtklein_C, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Revert of Remove SK_SUPPORT_LEGACY_DEEPFLATTENING. (patchset #1 id:1 of https://codereview.chromium.org/769953002/) Reason for revert: Breaks canary builds. Will reland after the Chromium change lands. Original issue's description: > Remove SK_SUPPORT_LEGACY_DEEPFLATTENING. > > This was needed for pictures before v33, and we're now requiring v35+. > > Will follow up with the same for skia/ext/pixel_ref_utils_unittest.cc > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/52c293547b973f7fb5de3c83f5062b07d759ab88 TBR=reed@google.com,mtklein@chromium.org NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/6e78293ee896020104ffc4c23b565073e9a49893

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1051 lines, -39 lines) Patch
M gm/imagefiltersbase.cpp View 4 chunks +16 lines, -0 lines 0 comments Download
M gm/imagefiltersgraph.cpp View 2 chunks +12 lines, -0 lines 0 comments Download
M include/core/SkColorFilter.h View 1 chunk +3 lines, -0 lines 0 comments Download
M include/core/SkDrawLooper.h View 1 chunk +3 lines, -0 lines 0 comments Download
M include/core/SkFlattenable.h View 4 chunks +26 lines, -0 lines 0 comments Download
M include/core/SkMaskFilter.h View 1 chunk +4 lines, -0 lines 0 comments Download
M include/core/SkPathEffect.h View 4 chunks +14 lines, -0 lines 0 comments Download
M include/core/SkRasterizer.h View 1 chunk +4 lines, -0 lines 0 comments Download
M include/core/SkShader.h View 1 chunk +3 lines, -0 lines 0 comments Download
M include/core/SkXfermode.h View 1 chunk +4 lines, -0 lines 0 comments Download
M include/effects/Sk1DPathEffect.h View 1 chunk +3 lines, -0 lines 0 comments Download
M include/effects/Sk2DPathEffect.h View 3 chunks +10 lines, -0 lines 0 comments Download
M include/effects/SkAvoidXfermode.h View 1 chunk +3 lines, -0 lines 0 comments Download
M include/effects/SkBitmapSource.h View 1 chunk +3 lines, -0 lines 0 comments Download
M include/effects/SkBlurDrawLooper.h View 1 chunk +3 lines, -0 lines 0 comments Download
M include/effects/SkBlurImageFilter.h View 1 chunk +3 lines, -0 lines 0 comments Download
M include/effects/SkColorCubeFilter.h View 1 chunk +3 lines, -0 lines 0 comments Download
M include/effects/SkColorFilterImageFilter.h View 1 chunk +3 lines, -0 lines 0 comments Download
M include/effects/SkColorMatrixFilter.h View 1 chunk +3 lines, -0 lines 0 comments Download
M include/effects/SkComposeImageFilter.h View 1 chunk +4 lines, -0 lines 0 comments Download
M include/effects/SkCornerPathEffect.h View 1 chunk +3 lines, -0 lines 0 comments Download
M include/effects/SkDashPathEffect.h View 1 chunk +3 lines, -0 lines 0 comments Download
M include/effects/SkDiscretePathEffect.h View 1 chunk +3 lines, -0 lines 0 comments Download
M include/effects/SkDisplacementMapEffect.h View 1 chunk +3 lines, -0 lines 0 comments Download
M include/effects/SkDropShadowImageFilter.h View 1 chunk +3 lines, -0 lines 0 comments Download
M include/effects/SkEmbossMaskFilter.h View 1 chunk +3 lines, -0 lines 0 comments Download
M include/effects/SkLayerDrawLooper.h View 1 chunk +7 lines, -0 lines 0 comments Download
M include/effects/SkLayerRasterizer.h View 1 chunk +3 lines, -0 lines 0 comments Download
M include/effects/SkLerpXfermode.h View 1 chunk +3 lines, -0 lines 0 comments Download
M include/effects/SkLightingImageFilter.h View 1 chunk +3 lines, -0 lines 0 comments Download
M include/effects/SkLumaColorFilter.h View 1 chunk +3 lines, -0 lines 0 comments Download
M include/effects/SkMagnifierImageFilter.h View 1 chunk +3 lines, -0 lines 0 comments Download
M include/effects/SkMatrixConvolutionImageFilter.h View 1 chunk +3 lines, -0 lines 0 comments Download
M include/effects/SkMatrixImageFilter.h View 1 chunk +3 lines, -0 lines 0 comments Download
M include/effects/SkMergeImageFilter.h View 1 chunk +3 lines, -0 lines 0 comments Download
M include/effects/SkMorphologyImageFilter.h View 3 chunks +10 lines, -0 lines 0 comments Download
M include/effects/SkOffsetImageFilter.h View 1 chunk +3 lines, -0 lines 0 comments Download
M include/effects/SkPerlinNoiseShader.h View 2 chunks +13 lines, -7 lines 0 comments Download
M include/effects/SkPictureImageFilter.h View 1 chunk +3 lines, -0 lines 0 comments Download
M include/effects/SkPixelXorXfermode.h View 1 chunk +3 lines, -0 lines 0 comments Download
M include/effects/SkRectShaderImageFilter.h View 1 chunk +3 lines, -0 lines 0 comments Download
M include/effects/SkTableMaskFilter.h View 1 chunk +3 lines, -0 lines 0 comments Download
M include/effects/SkTestImageFilters.h View 1 chunk +3 lines, -0 lines 0 comments Download
M include/effects/SkTileImageFilter.h View 1 chunk +3 lines, -0 lines 0 comments Download
M include/effects/SkTransparentShader.h View 1 chunk +4 lines, -0 lines 0 comments Download
M include/effects/SkXfermodeImageFilter.h View 1 chunk +3 lines, -0 lines 0 comments Download
M samplecode/ClockFaceView.cpp View 2 chunks +14 lines, -1 line 0 comments Download
M samplecode/SampleAll.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M src/core/SkBitmapProcShader.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/core/SkBitmapProcShader.cpp View 1 chunk +9 lines, -0 lines 0 comments Download
M src/core/SkBlitter.cpp View 1 chunk +9 lines, -0 lines 0 comments Download
M src/core/SkComposeShader.cpp View 1 chunk +14 lines, -0 lines 0 comments Download
M src/core/SkEmptyShader.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/core/SkFilterShader.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/core/SkFilterShader.cpp View 1 chunk +7 lines, -0 lines 0 comments Download
M src/core/SkFlattenable.cpp View 2 chunks +12 lines, -0 lines 0 comments Download
M src/core/SkLocalMatrixShader.h View 3 chunks +9 lines, -6 lines 0 comments Download
M src/core/SkLocalMatrixShader.cpp View 1 chunk +9 lines, -0 lines 0 comments Download
M src/core/SkPathEffect.cpp View 1 chunk +8 lines, -0 lines 0 comments Download
M src/core/SkPictureShader.cpp View 1 chunk +9 lines, -0 lines 0 comments Download
M src/core/SkShader.cpp View 2 chunks +17 lines, -0 lines 0 comments Download
M src/core/SkXfermode.cpp View 5 chunks +29 lines, -0 lines 0 comments Download
M src/core/SkXfermode_proccoeff.h View 2 chunks +5 lines, -1 line 0 comments Download
M src/effects/Sk1DPathEffect.cpp View 1 chunk +16 lines, -0 lines 0 comments Download
M src/effects/Sk2DPathEffect.cpp View 3 chunks +19 lines, -0 lines 0 comments Download
M src/effects/SkAlphaThresholdFilter.cpp View 2 chunks +12 lines, -0 lines 0 comments Download
M src/effects/SkArithmeticMode.cpp View 1 chunk +10 lines, -0 lines 0 comments Download
M src/effects/SkAvoidXfermode.cpp View 1 chunk +8 lines, -0 lines 0 comments Download
M src/effects/SkBitmapSource.cpp View 1 chunk +9 lines, -0 lines 0 comments Download
M src/effects/SkBlurDrawLooper.cpp View 1 chunk +13 lines, -0 lines 0 comments Download
M src/effects/SkBlurImageFilter.cpp View 1 chunk +12 lines, -0 lines 0 comments Download
M src/effects/SkBlurMaskFilter.cpp View 1 chunk +10 lines, -0 lines 0 comments Download
M src/effects/SkColorCubeFilter.cpp View 1 chunk +9 lines, -0 lines 0 comments Download
M src/effects/SkColorFilterImageFilter.cpp View 1 chunk +15 lines, -0 lines 0 comments Download
M src/effects/SkColorFilters.cpp View 1 chunk +11 lines, -0 lines 0 comments Download
M src/effects/SkColorMatrixFilter.cpp View 1 chunk +9 lines, -0 lines 0 comments Download
M src/effects/SkComposeImageFilter.cpp View 1 chunk +6 lines, -0 lines 0 comments Download
M src/effects/SkCornerPathEffect.cpp View 1 chunk +6 lines, -0 lines 0 comments Download
M src/effects/SkDashPathEffect.cpp View 1 chunk +25 lines, -0 lines 0 comments Download
M src/effects/SkDiscretePathEffect.cpp View 1 chunk +9 lines, -0 lines 0 comments Download
M src/effects/SkDisplacementMapEffect.cpp View 1 chunk +13 lines, -0 lines 0 comments Download
M src/effects/SkDropShadowImageFilter.cpp View 1 chunk +18 lines, -0 lines 0 comments Download
M src/effects/SkEmbossMaskFilter.cpp View 1 chunk +9 lines, -0 lines 0 comments Download
M src/effects/SkLayerRasterizer.cpp View 1 chunk +6 lines, -1 line 0 comments Download
M src/effects/SkLerpXfermode.cpp View 1 chunk +6 lines, -0 lines 0 comments Download
M src/effects/SkLightingImageFilter.cpp View 5 chunks +35 lines, -0 lines 0 comments Download
M src/effects/SkLumaColorFilter.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M src/effects/SkMagnifierImageFilter.cpp View 2 chunks +17 lines, -1 line 0 comments Download
M src/effects/SkMatrixConvolutionImageFilter.cpp View 1 chunk +44 lines, -0 lines 0 comments Download
M src/effects/SkMatrixImageFilter.cpp View 1 chunk +8 lines, -0 lines 0 comments Download
M src/effects/SkMergeImageFilter.cpp View 1 chunk +21 lines, -0 lines 0 comments Download
M src/effects/SkMorphologyImageFilter.cpp View 1 chunk +10 lines, -0 lines 0 comments Download
M src/effects/SkOffsetImageFilter.cpp View 1 chunk +9 lines, -0 lines 0 comments Download
M src/effects/SkPerlinNoiseShader.cpp View 3 chunks +22 lines, -1 line 0 comments Download
M src/effects/SkPictureImageFilter.cpp View 1 chunk +15 lines, -0 lines 0 comments Download
M src/effects/SkPixelXorXfermode.cpp View 1 chunk +6 lines, -0 lines 0 comments Download
M src/effects/SkRectShaderImageFilter.cpp View 1 chunk +7 lines, -0 lines 0 comments Download
M src/effects/SkTableColorFilter.cpp View 4 chunks +26 lines, -2 lines 0 comments Download
M src/effects/SkTableMaskFilter.cpp View 1 chunk +7 lines, -0 lines 0 comments Download
M src/effects/SkTestImageFilters.cpp View 1 chunk +8 lines, -0 lines 0 comments Download
M src/effects/SkTileImageFilter.cpp View 1 chunk +9 lines, -0 lines 0 comments Download
M src/effects/SkXfermodeImageFilter.cpp View 1 chunk +7 lines, -0 lines 0 comments Download
M src/effects/gradients/SkGradientShader.cpp View 1 chunk +50 lines, -0 lines 0 comments Download
M src/effects/gradients/SkLinearGradient.cpp View 3 chunks +11 lines, -3 lines 0 comments Download
M src/effects/gradients/SkRadialGradient.cpp View 3 chunks +11 lines, -3 lines 0 comments Download
M src/effects/gradients/SkSweepGradient.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/effects/gradients/SkSweepGradient.cpp View 3 chunks +10 lines, -3 lines 0 comments Download
M src/effects/gradients/SkTwoPointConicalGradient.cpp View 1 chunk +13 lines, -0 lines 0 comments Download
M src/effects/gradients/SkTwoPointRadialGradient.cpp View 3 chunks +13 lines, -2 lines 0 comments Download
M src/opts/SkXfermode_opts_SSE2.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/opts/SkXfermode_opts_SSE2.cpp View 1 chunk +7 lines, -0 lines 0 comments Download
M src/opts/SkXfermode_opts_arm_neon.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/opts/SkXfermode_opts_arm_neon.cpp View 1 chunk +6 lines, -0 lines 0 comments Download
M tests/ImageFilterTest.cpp View 5 chunks +15 lines, -8 lines 0 comments Download
M tests/PDFPrimitivesTest.cpp View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
mtklein
Created Revert of Remove SK_SUPPORT_LEGACY_DEEPFLATTENING.
6 years ago (2014-12-01 18:54:18 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/768183002/1
6 years ago (2014-12-01 18:55:10 UTC) #2
commit-bot: I haz the power
6 years ago (2014-12-01 18:56:10 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/6e78293ee896020104ffc4c23b565073e9a49893

Powered by Google App Engine
This is Rietveld 408576698