Issue 7639020: Perform TODO(gc) cleanup for TODO-lockdown.

Issue 7639020: Perform TODO(gc) cleanup for TODO-lockdown. (Closed)

Created:
9 years, 4 months ago by Vyacheslav Egorov (Chromium)

Modified:
9 years, 4 months ago

Reviewers:
Erik Corry

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/experimental/gc

Visibility:
Public.

Description

Perform TODO(gc) cleanup for TODO-lockdown. R=erik.corry@gmail.com Committed: http://code.google.com/p/v8/source/detail?r=9002

Patch Set 1 #

Total comments: 2

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+96 lines, -246 lines)			Patch
M	src/arm/assembler-arm-inl.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/arm/code-stubs-arm.cc	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/arm/deoptimizer-arm.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/arm/macro-assembler-arm.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/heap.h	View	3 chunks	+1 line, -3 lines	0 comments	Download
M	src/heap.cc	View	15 chunks	+22 lines, -20 lines	0 comments	Download
M	src/heap-inl.h	View	3 chunks	+3 lines, -5 lines	0 comments	Download
M	src/ia32/assembler-ia32-inl.h	View	2 chunks	+4 lines, -2 lines	0 comments	Download
M	src/ia32/code-stubs-ia32.cc	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/ia32/deoptimizer-ia32.cc	View	3 chunks	+3 lines, -4 lines	0 comments	Download
M	src/ia32/macro-assembler-ia32.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/ic-inl.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/incremental-marking.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/liveedit.cc	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/mark-compact.h	View	1 chunk	+0 lines, -12 lines	0 comments	Download
M	src/mark-compact.cc	View	11 chunks	+7 lines, -86 lines	1 comment	Download
M	src/objects.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/objects-inl.h	View	3 chunks	+8 lines, -6 lines	0 comments	Download
M	src/platform.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/profile-generator.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/serialize.cc	View	1 chunk	+4 lines, -5 lines	0 comments	Download
M	src/spaces.h	View	7 chunks	+7 lines, -32 lines	1 comment	Download
M	src/spaces.cc	View	4 chunks	+3 lines, -22 lines	0 comments	Download
M	src/spaces-inl.h	View	2 chunks	+9 lines, -9 lines	0 comments	Download
M	src/store-buffer.h	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	src/store-buffer.cc	View	7 chunks	+10 lines, -15 lines	0 comments	Download
M	src/x64/assembler-x64-inl.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/x64/code-stubs-x64.cc	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/x64/macro-assembler-x64.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/cctest/test-mark-compact.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/cctest/test-spaces.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Erik Corry

9 years, 4 months ago (2011-08-16 11:17:20 UTC) #2

LGTM

http://codereview.chromium.org/7639020/diff/1/src/mark-compact.cc
File src/mark-compact.cc (right):

http://codereview.chromium.org/7639020/diff/1/src/mark-compact.cc#newcode406
src/mark-compact.cc:406: // order which is not implemented for incremental
marking.
Do we have a bug number for map collection?

http://codereview.chromium.org/7639020/diff/1/src/spaces.h
File src/spaces.h (right):

http://codereview.chromium.org/7639020/diff/1/src/spaces.h#newcode2435
src/spaces.h:2435: inline explicit PointerChunkIterator(Heap* heap_);
No underscore here.

Expand Messages | Collapse Messages