Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Unified Diff: src/spaces-inl.h

Issue 7639020: Perform TODO(gc) cleanup for TODO-lockdown. (Closed) Base URL: https://v8.googlecode.com/svn/branches/experimental/gc
Patch Set: Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« src/spaces.h ('K') | « src/spaces.cc ('k') | src/store-buffer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/spaces-inl.h
diff --git a/src/spaces-inl.h b/src/spaces-inl.h
index 644ab2eaa31a0550be76612fb45daa6bafcdaa3b..75c27d6b1c839eb50cd2fd98b4368d887fb0992e 100644
--- a/src/spaces-inl.h
+++ b/src/spaces-inl.h
@@ -216,12 +216,11 @@ MemoryChunk* MemoryChunk::FromAnyPointerAddress(Address addr) {
}
-// TODO(gc) ISOLATESMERGE HEAP
-PointerChunkIterator::PointerChunkIterator()
+PointerChunkIterator::PointerChunkIterator(Heap* heap)
: state_(kOldPointerState),
- old_pointer_iterator_(HEAP->old_pointer_space()),
- map_iterator_(HEAP->map_space()),
- lo_iterator_(HEAP->lo_space()) { }
+ old_pointer_iterator_(heap->old_pointer_space()),
+ map_iterator_(heap->map_space()),
+ lo_iterator_(heap->lo_space()) { }
Page* Page::next_page() {
@@ -354,10 +353,11 @@ void NewSpace::ShrinkStringAtAllocationBoundary(String* string, int length) {
bool FreeListNode::IsFreeListNode(HeapObject* object) {
- // TODO(gc) ISOLATES MERGE
- return object->map() == HEAP->raw_unchecked_free_space_map()
- || object->map() == HEAP->raw_unchecked_one_pointer_filler_map()
- || object->map() == HEAP->raw_unchecked_two_pointer_filler_map();
+ Map* map = object->map();
+ Heap* heap = object->GetHeap();
+ return map == heap->raw_unchecked_free_space_map()
+ || map == heap->raw_unchecked_one_pointer_filler_map()
+ || map == heap->raw_unchecked_two_pointer_filler_map();
}
} } // namespace v8::internal
« src/spaces.h ('K') | « src/spaces.cc ('k') | src/store-buffer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698