src/x64/assembler-x64-inl.h - Issue 7639020: Perform TODO(gc) cleanup for TODO-lockdown.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/assembler-x64-inl.h

Issue 7639020: Perform TODO(gc) cleanup for TODO-lockdown. (Closed) Base URL: https://v8.googlecode.com/svn/branches/experimental/gc

Patch Set: Created 9 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/x64/assembler-x64-inl.h

diff --git a/src/x64/assembler-x64-inl.h b/src/x64/assembler-x64-inl.h

index cbe2753210d2c31975d6a11ae0cf2237a78edc79..6be1eb732dbf38232bf2db48bc1f51317d46ce82 100644

--- a/src/x64/assembler-x64-inl.h

+++ b/src/x64/assembler-x64-inl.h

@@ -244,7 +244,8 @@ void RelocInfo::set_target_address(Address target, Code* code) {

Assembler::set_target_address_at(pc_, target);

Object* target_code = Code::GetCodeFromTargetAddress(target);

if (code != NULL) {

- // TODO(gc) We do not compact code pages.

+ // TODO(1550) We are passing NULL as a slot because code can never be on

+ // evacuation candidate.

code->GetHeap()->incremental_marking()->RecordWrite(

code, NULL, HeapObject::cast(target_code));

}