src/ia32/macro-assembler-ia32.cc - Issue 7639020: Perform TODO(gc) cleanup for TODO-lockdown.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ia32/macro-assembler-ia32.cc

Issue 7639020: Perform TODO(gc) cleanup for TODO-lockdown. (Closed) Base URL: https://v8.googlecode.com/svn/branches/experimental/gc

Patch Set: Created 9 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ia32/macro-assembler-ia32.cc

diff --git a/src/ia32/macro-assembler-ia32.cc b/src/ia32/macro-assembler-ia32.cc

index e05c87e77dc55ac030b54825f590433035aec4b9..8876a192c74436dc65d3108cfa1590ef16bb1e2c 100644

--- a/src/ia32/macro-assembler-ia32.cc

+++ b/src/ia32/macro-assembler-ia32.cc

@@ -1405,8 +1405,8 @@ void MacroAssembler::TryGetFunctionPrototype(Register function,

void MacroAssembler::CallStub(CodeStub* stub, unsigned ast_id) {

+ // TODO(1599): Do not call stubs from stubs that do not allow stub calls.

// ASSERT(allow_stub_calls()); // Calls are not allowed in some stubs.

- // TODO(gc): Fix this!

call(stub->GetCode(), RelocInfo::CODE_TARGET, ast_id);

}