Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Side by Side Diff: src/liveedit.cc

Issue 7639020: Perform TODO(gc) cleanup for TODO-lockdown. (Closed) Base URL: https://v8.googlecode.com/svn/branches/experimental/gc
Patch Set: Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 964 matching lines...) Expand 10 before | Expand all | Expand 10 after
975 975
976 // Post-visiting method that iterates over all collected references and 976 // Post-visiting method that iterates over all collected references and
977 // modifies them. 977 // modifies them.
978 void Replace(Code* substitution) { 978 void Replace(Code* substitution) {
979 for (int i = 0; i < rvalues_.length(); i++) { 979 for (int i = 0; i < rvalues_.length(); i++) {
980 *(rvalues_[i]) = substitution; 980 *(rvalues_[i]) = substitution;
981 } 981 }
982 Address substitution_entry = substitution->instruction_start(); 982 Address substitution_entry = substitution->instruction_start();
983 for (int i = 0; i < reloc_infos_.length(); i++) { 983 for (int i = 0; i < reloc_infos_.length(); i++) {
984 reloc_infos_[i].set_target_address(substitution_entry, NULL); 984 reloc_infos_[i].set_target_address(substitution_entry, NULL);
985 // TODO(gc) more precise barrier.
986 // TODO(gc) ISOLATES MERGE: code object should have heap() accessor.
987 substitution->GetHeap()->incremental_marking()->RecordWriteOf( 985 substitution->GetHeap()->incremental_marking()->RecordWriteOf(
988 substitution); 986 substitution);
989 } 987 }
990 for (int i = 0; i < code_entries_.length(); i++) { 988 for (int i = 0; i < code_entries_.length(); i++) {
991 Address entry = code_entries_[i]; 989 Address entry = code_entries_[i];
992 Memory::Address_at(entry) = substitution_entry; 990 Memory::Address_at(entry) = substitution_entry;
993 } 991 }
994 } 992 }
995 993
996 private: 994 private:
(...skipping 790 matching lines...) Expand 10 before | Expand all | Expand 10 after
1787 1785
1788 bool LiveEditFunctionTracker::IsActive(Isolate* isolate) { 1786 bool LiveEditFunctionTracker::IsActive(Isolate* isolate) {
1789 return false; 1787 return false;
1790 } 1788 }
1791 1789
1792 #endif // ENABLE_DEBUGGER_SUPPORT 1790 #endif // ENABLE_DEBUGGER_SUPPORT
1793 1791
1794 1792
1795 1793
1796 } } // namespace v8::internal 1794 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/incremental-marking.h ('k') | src/mark-compact.h » ('j') | src/mark-compact.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698